Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static methods are missing from angular2.d.ts #3175

Closed
alexeagle opened this issue Jul 21, 2015 · 7 comments
Closed

static methods are missing from angular2.d.ts #3175

alexeagle opened this issue Jul 21, 2015 · 7 comments
Assignees
Labels
area: build & ci Related the build and CI infrastructure of the project effort1: hours type: bug/fix
Milestone

Comments

@alexeagle
Copy link
Contributor

Reported in DefinitelyTyped/DefinitelyTyped#4769

our current published .d.ts contains

class Validators {
}

but the original source in forms/validators.ts contains

export class Validators {
  static required(c: modelModule.Control): StringMap<string, boolean> {
...
@alexeagle
Copy link
Contributor Author

Have to push this off since I'm occupied with the syncmaster on-duty.

@NathanWalker
Copy link
Contributor

Hope this makes it in 34 ... If I had time to offer a PR I would, if this is still open in couple days, I could certainly help.

@alexeagle
Copy link
Contributor Author

Probably not in 34 as that is getting cut today.
I have not started on this so if you'd like to send a PR it would be really
appreciated!

On Wed, Aug 5, 2015 at 1:50 PM Nathan Walker notifications@github.com
wrote:

Hope this makes it in 34 ... If I had time to offer a PR I would, if this
is still open in couple days, I could certainly help.


Reply to this email directly or view it on GitHub
#3175 (comment).

@alexeagle
Copy link
Contributor Author

Punting to next milestone, maybe @NathanWalker will get to this before I can.

@alexeagle alexeagle modified the milestones: alpha-35, alpha-34 Aug 6, 2015
@NathanWalker
Copy link
Contributor

@alexeagle sorry I haven't been able to get to this yet.
I did look at the typings template last week and the setup had changed a bit since some of the earlier alpha versions and was unable to understand fully what needed to be done to make the static methods available in the .d.ts file.

@alexeagle
Copy link
Contributor Author

Thank you for letting me know the status! I'll try to look today or tomorrow.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: build & ci Related the build and CI infrastructure of the project effort1: hours type: bug/fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants