-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compiler-cli): fix typo in diagnostic template info #32684
Conversation
2ed700d
to
e8ed284
Compare
@gkalpak can you please review. |
c0a97ec
to
e9ae21d
Compare
There seems to be some Chrome version mismatch which is responsible for failing some checks. |
Thx, @cRAN-cg 🎉 |
95ade0b
to
e3ce203
Compare
@gkalpak Thanks a ton for guiding me. Apologies for not abiding by the guidelines. Will keep that in mind for the next time. It's my first PR to angular so am really very excited 🤩. Thanks for your time and bearing with me. 👍 Thanks again 😊 |
No worries, @cRAN-cg! Thx for fixing it up 👍 (BTW, |
e3ce203
to
488a5ad
Compare
Done sire 🛠 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
merge-assistance: global approval |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Closes #32662.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: 32662
What is the new behavior?
Explicit context reference error now reads
The template context does not define a member called
Does this PR introduce a breaking change?
Other information