New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(docs-infra): update @angular/cli 9.0.0-rc.0 and @angular/* to 9.0.0-rc.1 #33547
Conversation
You can preview 13acb2e at https://pr33547-13acb2e.ngbuilds.io/. |
13acb2e
to
406fbf7
Compare
You can preview 406fbf7 at https://pr33547-406fbf7.ngbuilds.io/. |
406fbf7
to
85a8aa5
Compare
You can preview 85a8aa5 at https://pr33547-85a8aa5.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wanna try using --experimentalRollupPass
? 😉
aio/scripts/_payload-limits.json
Outdated
@@ -3,7 +3,7 @@ | |||
"master": { | |||
"uncompressed": { | |||
"runtime-es2015": 2987, | |||
"main-es2015": 460590, | |||
"main-es2015": 463485, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3k greater :-/
85a8aa5
to
e12873f
Compare
Added another commit to update |
You can preview e12873f at https://pr33547-e12873f.ngbuilds.io/. |
@filipesilva, I tried
|
FYI: |
I expected a better improvement, will have to look into it,. |
@@ -3,7 +3,7 @@ | |||
"master": { | |||
"uncompressed": { | |||
"runtime-es2015": 2987, | |||
"main-es2015": 460590, | |||
"main-es2015": 464973, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gkalpak could you please test if this regression is coming from CLI changes or fw changes by reverting the cli update?
we should let this PR merge as is, but it would be good to know where the size regression came from.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed the size increase is caused by framework. (I got the exact same number after reverting the CLI update.)
Note that similar size regressions have been seen in integration projects recently (tracked in FW-1665). Not sure they are related, but I wouldn't be surprised 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the CLI we also saw it in angular/angular-cli#16099, added potential causes there.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information