Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(docs-infra): update @angular/cli 9.0.0-rc.0 and @angular/* to 9.0.0-rc.1 #33547

Closed
wants to merge 4 commits into from
Closed

build(docs-infra): update @angular/cli 9.0.0-rc.0 and @angular/* to 9.0.0-rc.1 #33547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6dfddbf
build(docs-infra): update `aio` payload size
gkalpak Nov 2, 2019
fe50c45
build(docs-infra): update @angular/cli to 9.0.0-rc.0
gkalpak Nov 2, 2019
a9c4b35
build(docs-infra): update @angular/* to 9.0.0-rc.0
gkalpak Nov 2, 2019
e12873f
build(docs-infra): update @angular/* to 9.0.0-rc.1
gkalpak Nov 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Expand Up @@ -365,7 +365,7 @@ jobs:
# Compile dependencies to ivy
# Running `ngcc` here (instead of implicitly via `ng build`) allows us to take advantage of
# the parallel, async mode speed-up (~20-25s on CI).
- run: yarn --cwd aio ivy-ngcc --properties es2015
- run: yarn --cwd aio ngcc --properties es2015
# Build aio
- run: yarn --cwd aio build --progress=false
# Lint the code
Expand Down
30 changes: 15 additions & 15 deletions aio/package.json
View file
Open in desktop
Expand Up @@ -87,28 +87,28 @@
},
"private": true,
"dependencies": {
"@angular/animations": "^9.0.0-next.10",
"@angular/animations": "^9.0.0-rc.1",
"@angular/cdk": "9.0.0-next.0",
"@angular/common": "^9.0.0-next.10",
"@angular/compiler": "^9.0.0-next.10",
"@angular/core": "^9.0.0-next.10",
"@angular/elements": "^9.0.0-next.10",
"@angular/forms": "^9.0.0-next.10",
"@angular/common": "^9.0.0-rc.1",
"@angular/compiler": "^9.0.0-rc.1",
"@angular/core": "^9.0.0-rc.1",
"@angular/elements": "^9.0.0-rc.1",
"@angular/forms": "^9.0.0-rc.1",
"@angular/material": "9.0.0-next.0",
"@angular/platform-browser": "^9.0.0-next.10",
"@angular/platform-browser-dynamic": "^9.0.0-next.10",
"@angular/router": "^9.0.0-next.10",
"@angular/service-worker": "^9.0.0-next.10",
"@angular/platform-browser": "^9.0.0-rc.1",
"@angular/platform-browser-dynamic": "^9.0.0-rc.1",
"@angular/router": "^9.0.0-rc.1",
"@angular/service-worker": "^9.0.0-rc.1",
"@webcomponents/custom-elements": "^1.2.0",
"rxjs": "^6.5.3",
"tslib": "^1.10.0",
"zone.js": "~0.10.2"
},
"devDependencies": {
"@angular-devkit/build-angular": "0.900.0-next.11",
"@angular/cli": "9.0.0-next.11",
"@angular/compiler-cli": "^9.0.0-next.10",
"@angular/language-service": "^9.0.0-next.10",
"@angular-devkit/build-angular": "0.900.0-rc.0",
"@angular/cli": "9.0.0-rc.0",
"@angular/compiler-cli": "^9.0.0-rc.1",
"@angular/language-service": "^9.0.0-rc.1",
"@types/jasmine": "^3.4.2",
"@types/jasminewd2": "^2.0.8",
"@types/lunr": "^2.3.2",
Expand Down Expand Up @@ -175,4 +175,4 @@
"xregexp": "^4.0.0",
"yargs": "^7.0.2"
}
}
}
2 changes: 1 addition & 1 deletion aio/scripts/_payload-limits.json
View file
Open in desktop
Expand Up @@ -3,7 +3,7 @@
"master": {
"uncompressed": {
"runtime-es2015": 2987,
"main-es2015": 460590,
"main-es2015": 464973,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gkalpak could you please test if this regression is coming from CLI changes or fw changes by reverting the cli update?

we should let this PR merge as is, but it would be good to know where the size regression came from.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed the size increase is caused by framework. (I got the exact same number after reverting the CLI update.)

Note that similar size regressions have been seen in integration projects recently (tracked in FW-1665). Not sure they are related, but I wouldn't be surprised 😃

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the CLI we also saw it in angular/angular-cli#16099, added potential causes there.

"polyfills-es2015": 52503
}
}
Expand Down