Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zone.js package is missing from circleci build artifacts #33686

Closed
filipesilva opened this issue Nov 8, 2019 · 1 comment
Closed

zone.js package is missing from circleci build artifacts #33686

filipesilva opened this issue Nov 8, 2019 · 1 comment
Assignees
@gkalpak
Labels
area: build & ci Related the build and CI infrastructure of the project area: zones type: bug/fix
Milestone
needsTriage

Comments

@filipesilva
Copy link
Contributor

This prevents using the artifacts directly in dist/packages-dist.

cc @gkalpak
@filipesilva filipesilva mentioned this issue Nov 8, 2019
Closed
@IgorMinar IgorMinar added area: build & ci Related the build and CI infrastructure of the project area: zones labels Nov 8, 2019
@ngbot ngbot bot modified the milestone: needsTriage Nov 8, 2019
@gkalpak gkalpak self-assigned this Nov 11, 2019
gkalpak added a commit to gkalpak/angular that referenced this issue Nov 11, 2019
@gkalpak
ci: publish tarballs for the zone.js package as CI build artifacts
c03e41e 
Since angular#33321, Angular packages have been persisted on each build as
CircleCI build artifacts (`.tgz` files), which can be used to install
dependencies on a project (for the purpose of testing or trying out a
change before a PR being merged and without having to build the packages
from source locally).

Previously, only packages published to npm under the `@angular` scope
were persisted as build artifacts.

This commit adds the `zone.js` package to the list of persisted
packages.

Fixes angular#33686
@gkalpak gkalpak mentioned this issue Nov 11, 2019
Closed
gkalpak added a commit to gkalpak/angular that referenced this issue Nov 11, 2019
@gkalpak
ci: publish tarballs for the zone.js package as CI build artifacts
ada7ccd 
Since angular#33321, Angular packages have been persisted on each build as
CircleCI build artifacts (`.tgz` files), which can be used to install
dependencies on a project (for the purpose of testing or trying out a
change before a PR being merged and without having to build the packages
from source locally).

Previously, only packages published to npm under the `@angular` scope
were persisted as build artifacts.

This commit adds the `zone.js` package to the list of persisted
packages.

Fixes angular#33686
gkalpak added a commit to gkalpak/angular that referenced this issue Nov 11, 2019
@gkalpak
ci: publish tarballs for the zone.js package as CI build artifacts
bcb6cd4 
Since angular#33321, Angular packages have been persisted on each build as
CircleCI build artifacts (`.tgz` files), which can be used to install
dependencies on a project (for the purpose of testing or trying out a
change before a PR being merged and without having to build the packages
from source locally).

Previously, only packages published to npm under the `@angular` scope
were persisted as build artifacts.

This commit adds the `zone.js` package to the list of persisted
packages.

Fixes angular#33686
gkalpak added a commit to gkalpak/angular that referenced this issue Nov 11, 2019
@gkalpak
ci: publish tarballs for the zone.js package as CI build artifacts
836cdd2 
Since angular#33321, Angular packages have been persisted on each build as
CircleCI build artifacts (`.tgz` files), which can be used to install
dependencies on a project (for the purpose of testing or trying out a
change before a PR being merged and without having to build the packages
from source locally).

Previously, only packages published to npm under the `@angular` scope
were persisted as build artifacts.

This commit adds the `zone.js` package to the list of persisted
packages.

Fixes angular#33686
kara pushed a commit that referenced this issue Nov 12, 2019
@gkalpak @kara
ci: publish tarballs for the zone.js package as CI build artifacts (#…
bb9b803 
…33733)

Since #33321, Angular packages have been persisted on each build as
CircleCI build artifacts (`.tgz` files), which can be used to install
dependencies on a project (for the purpose of testing or trying out a
change before a PR being merged and without having to build the packages
from source locally).

Previously, only packages published to npm under the `@angular` scope
were persisted as build artifacts.

This commit adds the `zone.js` package to the list of persisted
packages.

Fixes #33686

PR Close #33733
@kara kara closed this as completed in 2ce9cda Nov 12, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gkalpak gkalpak

Labels
area: build & ci Related the build and CI infrastructure of the project area: zones type: bug/fix
Projects
None yet
Milestone
needsTriage
Development

Successfully merging a pull request may close this issue.

ci: publish tarballs for the zone.js package as CI build artifacts gkalpak/angular
3 participants
@IgorMinar @filipesilva @gkalpak