Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zone.js package is missing from circleci build artifacts #33686

Closed
filipesilva opened this issue Nov 8, 2019 · 0 comments

Comments

@filipesilva
Copy link
Member

@filipesilva filipesilva commented Nov 8, 2019

This prevents using the artifacts directly in dist/packages-dist.

cc @gkalpak

@ngbot ngbot bot modified the milestone: needsTriage Nov 8, 2019
@gkalpak gkalpak self-assigned this Nov 11, 2019
gkalpak added a commit to gkalpak/angular that referenced this issue Nov 11, 2019
Since angular#33321, Angular packages have been persisted on each build as
CircleCI build artifacts (`.tgz` files), which can be used to install
dependencies on a project (for the purpose of testing or trying out a
change before a PR being merged and without having to build the packages
from source locally).

Previously, only packages published to npm under the `@angular` scope
were persisted as build artifacts.

This commit adds the `zone.js` package to the list of persisted
packages.

Fixes angular#33686
gkalpak added a commit to gkalpak/angular that referenced this issue Nov 11, 2019
Since angular#33321, Angular packages have been persisted on each build as
CircleCI build artifacts (`.tgz` files), which can be used to install
dependencies on a project (for the purpose of testing or trying out a
change before a PR being merged and without having to build the packages
from source locally).

Previously, only packages published to npm under the `@angular` scope
were persisted as build artifacts.

This commit adds the `zone.js` package to the list of persisted
packages.

Fixes angular#33686
gkalpak added a commit to gkalpak/angular that referenced this issue Nov 11, 2019
Since angular#33321, Angular packages have been persisted on each build as
CircleCI build artifacts (`.tgz` files), which can be used to install
dependencies on a project (for the purpose of testing or trying out a
change before a PR being merged and without having to build the packages
from source locally).

Previously, only packages published to npm under the `@angular` scope
were persisted as build artifacts.

This commit adds the `zone.js` package to the list of persisted
packages.

Fixes angular#33686
gkalpak added a commit to gkalpak/angular that referenced this issue Nov 11, 2019
Since angular#33321, Angular packages have been persisted on each build as
CircleCI build artifacts (`.tgz` files), which can be used to install
dependencies on a project (for the purpose of testing or trying out a
change before a PR being merged and without having to build the packages
from source locally).

Previously, only packages published to npm under the `@angular` scope
were persisted as build artifacts.

This commit adds the `zone.js` package to the list of persisted
packages.

Fixes angular#33686
kara added a commit that referenced this issue Nov 12, 2019
…33733)

Since #33321, Angular packages have been persisted on each build as
CircleCI build artifacts (`.tgz` files), which can be used to install
dependencies on a project (for the purpose of testing or trying out a
change before a PR being merged and without having to build the packages
from source locally).

Previously, only packages published to npm under the `@angular` scope
were persisted as build artifacts.

This commit adds the `zone.js` package to the list of persisted
packages.

Fixes #33686

PR Close #33733
@kara kara closed this in 2ce9cda Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.