ci: publish tarballs for all Angular packages as build artifacts on PR builds #33321

gkalpak · 2019-10-22T14:08:19Z

Previously, when one wanted to try out the changes from a PR before it was merged, they had to check out the PR locally and build the Angular packages themselves (which is time-consuming and wasteful given that the packages have already been built on CI).

This commit persists all Angular packages on each build as .tgz files, which can be used to install dependencies on an project (supported by both npm and yarn).

CircleCI build artifacts an be used for longer-term storage of the outputs of a build and are designed to be useful around the time of the build, which suits our needs.

googlebot · 2019-10-22T14:08:45Z

☹️ Sorry, but only Googlers may change the label cla: yes.

…R builds Previously, when one wanted to try out the changes from a PR before it was merged, they had to check out the PR locally and build the Angular packages themselves (which is time-consuming and wasteful given that the packages have already been built on CI). This commit persists all Angular packages on each build as `.tgz` files, which can be used to install dependencies on an project (supported by both [npm][1] and [yarn][2]). In addition to individual `.tgz` files for each package, a `.tgz` file including all packages is also stored, which can be used to test the packages locally by overwriting the ones in the `node_modules/` directory of a project. CircleCI [build artifacts][3] an be used for longer-term storage of the outputs of a build and are designed to be useful around the time of the build, which suits our needs. [1]: https://docs.npmjs.com/cli/install.html [2]: https://yarnpkg.com/lang/en/docs/cli/add [3]: https://circleci.com/docs/2.0/artifacts

…ts on PR builds

josephperrott

Overall LGTM, we will need to have @IgorMinar review the docs/DEVELOPER.md change as well.

josephperrott · 2019-10-23T14:13:57Z

docs/DEVELOPER.md

-Rather than requiring them to pull your Pull Request and build Angular locally, you can
-publish the `*-builds` snapshots just like our CircleCI build does.
+Rather than requiring them to pull your Pull Request and build Angular locally, you can publish
+snapshots of the Angular packages.


In a few locations in this doc, the phrase "you can publish" is used. I am worried that it sounds like an action that the user needs to take rather than something that will happen for them.

Should we say something like:

Rather than requiring them to pull your Pull Request and build Angular locally, they can depend on snapshots of the Angular packages created for the Pull Request by each CI run.

Good point. (This is actually the only occurrence where the phrase is inaccurate (in other places they do indeed need to take an action) 😁)
Given that the snapshots are not published by CI in all methods described below, I changed it to:

Rather than requiring them to pull your Pull Request and build Angular locally, they can depend on snapshots of the Angular packages created based on the code in the Pull Request.

I also updated the Publishing to GitHub repos section to make it clear that they need to have built the packages locally first.

josephperrott · 2019-10-23T14:15:45Z

scripts/ci/create-package-archives.sh

@@ -0,0 +1,29 @@
+#!/usr/bin/env bash


Can you add a bit more logging, expressing when the all packages tarball is created and when things start and complete?

…ts on PR builds

IgorMinar

wow. this is awesome! thanks

PR Close #33321

…R builds (#33321) Previously, when one wanted to try out the changes from a PR before it was merged, they had to check out the PR locally and build the Angular packages themselves (which is time-consuming and wasteful given that the packages have already been built on CI). This commit persists all Angular packages on each build as `.tgz` files, which can be used to install dependencies on an project (supported by both [npm][1] and [yarn][2]). In addition to individual `.tgz` files for each package, a `.tgz` file including all packages is also stored, which can be used to test the packages locally by overwriting the ones in the `node_modules/` directory of a project. CircleCI [build artifacts][3] an be used for longer-term storage of the outputs of a build and are designed to be useful around the time of the build, which suits our needs. [1]: https://docs.npmjs.com/cli/install.html [2]: https://yarnpkg.com/lang/en/docs/cli/add [3]: https://circleci.com/docs/2.0/artifacts PR Close #33321

AndrewKushnir · 2019-10-24T16:57:35Z

@gkalpak there was a conflict merging this PR to patch branch, so I merged it to master. Could you please create a followup PR targeting patch branch with the necessary changes? Thank you.

gkalpak · 2019-10-25T10:02:31Z

Thx, @AndrewKushnir! The CircleCI config seems to have deviated quite a bit on the patch branch. Thus, I don't think this is worth backporting. Let's keep it as master-only.

Since angular#33321, Angular packages have been persisted on each build as CircleCI build artifacts (`.tgz` files), which can be used to install dependencies on a project (for the purpose of testing or trying out a change before a PR being merged and without having to build the packages from source locally). Previously, only packages published to npm under the `@angular` scope were persisted as build artifacts. This commit adds the `zone.js` package to the list of persisted packages. Fixes angular#33686

…33733) Since #33321, Angular packages have been persisted on each build as CircleCI build artifacts (`.tgz` files), which can be used to install dependencies on a project (for the purpose of testing or trying out a change before a PR being merged and without having to build the packages from source locally). Previously, only packages published to npm under the `@angular` scope were persisted as build artifacts. This commit adds the `zone.js` package to the list of persisted packages. Fixes #33686 PR Close #33733

angular-automatic-lock-bot · 2019-12-12T16:01:55Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Oct 22, 2019

gkalpak added area: build & ci Related the build and CI infrastructure of the project state: WIP target: patch This PR is targeted for the next patch release and removed cla: yes labels Oct 22, 2019

googlebot added the cla: yes label Oct 22, 2019

ngbot bot modified the milestone: needsTriage Oct 22, 2019

gkalpak force-pushed the ci-publish-artifacts branch 2 times, most recently from fd27727 to c6eefde Compare October 22, 2019 14:47

gkalpak added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Oct 22, 2019

gkalpak marked this pull request as ready for review October 22, 2019 14:48

gkalpak requested a review from a team as a code owner October 22, 2019 14:48

gkalpak force-pushed the ci-publish-artifacts branch from 8cb08d1 to 9d445c9 Compare October 22, 2019 15:38

gkalpak added 3 commits October 23, 2019 16:29

docs: minor DEVELOPER.md clean-up

c6f77ff

ci: use YAML aliases to define branch filters for CircleCI jobs

18c0b8e

gkalpak force-pushed the ci-publish-artifacts branch from 9d445c9 to 450a084 Compare October 23, 2019 13:29

gkalpak requested a review from IgorMinar as a code owner October 23, 2019 13:29

fixup! ci: publish tarballs for all Angular packages as build artifac…

9b7c0de

…ts on PR builds

gkalpak force-pushed the ci-publish-artifacts branch from 450a084 to 9b7c0de Compare October 23, 2019 13:36

josephperrott approved these changes Oct 23, 2019

View reviewed changes

fixup! ci: publish tarballs for all Angular packages as build artifac…

7ae76fe

…ts on PR builds

IgorMinar approved these changes Oct 23, 2019

View reviewed changes

IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 23, 2019

AndrewKushnir removed the target: patch This PR is targeted for the next patch release label Oct 24, 2019

AndrewKushnir added the target: major This PR is targeted for the next major release label Oct 24, 2019

AndrewKushnir closed this in 122f755 Oct 24, 2019

AndrewKushnir pushed a commit that referenced this pull request Oct 24, 2019

ci: use YAML aliases to define branch filters for CircleCI jobs (#33321)

22e4838

PR Close #33321

gkalpak mentioned this pull request Nov 11, 2019

ci: publish tarballs for the zone.js package as CI build artifacts #33733

Closed

gkalpak deleted the ci-publish-artifacts branch November 11, 2019 19:30

angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: publish tarballs for all Angular packages as build artifacts on PR builds #33321

ci: publish tarballs for all Angular packages as build artifacts on PR builds #33321

gkalpak commented Oct 22, 2019

googlebot commented Oct 22, 2019

josephperrott left a comment

josephperrott Oct 23, 2019

gkalpak Oct 23, 2019

josephperrott Oct 23, 2019

gkalpak Oct 23, 2019

IgorMinar left a comment

AndrewKushnir commented Oct 24, 2019

gkalpak commented Oct 25, 2019

angular-automatic-lock-bot bot commented Dec 12, 2019

ci: publish tarballs for all Angular packages as build artifacts on PR builds #33321

ci: publish tarballs for all Angular packages as build artifacts on PR builds #33321

Conversation

gkalpak commented Oct 22, 2019

googlebot commented Oct 22, 2019

josephperrott left a comment

Choose a reason for hiding this comment

josephperrott Oct 23, 2019

Choose a reason for hiding this comment

gkalpak Oct 23, 2019

Choose a reason for hiding this comment

josephperrott Oct 23, 2019

Choose a reason for hiding this comment

gkalpak Oct 23, 2019

Choose a reason for hiding this comment

IgorMinar left a comment

Choose a reason for hiding this comment

AndrewKushnir commented Oct 24, 2019

gkalpak commented Oct 25, 2019

angular-automatic-lock-bot bot commented Dec 12, 2019