Missing space between currency code and value in currency pipe #2

[musterknabe]

🐞 bug report

Affected Package

The issue is caused by package @angular/common

Is this a regression?

No

Description

The original bug was closed by a bot before it was solved (see #20708).

@ocombe wrote:

Since CLDR doesn't contain formats for finance currencies, I don't think that we can fix that. They have formats for currency accounting, but it doesn't seem to be that.
The description for the currency pattern that we use is:

Used for currency values. A currency symbol (¤) is will be replaced by the appropriate currency symbol for whatever currency is being formatted. The choice of whether to use the international currency symbols (USD, EUR, JAY, RUB,…) or localized symbols ($, €, ¥, руб.,…) is up to the application program that uses CLDR.

Which seem to point to the fact that we are indeed using the correct pattern.

You are using the correct pattern, but according to the CLDR website (http://cldr.unicode.org/translation/number-patterns) there should be a space between currency code and numbers:

¤ | This will be replaced by a currency symbol, such as $ or USD. Note: by default a space is automatically added between letters in a currency symbol and adjacent numbers. So you don't need to add a space between them if your language writes "$12" but "USD 12".

[musterknabe]

Firefox, which uses the same CLDR data internally for locale strings, formats it correctly. And so does Chrome:

(1000).toLocaleString('en-GB', {style: 'currency', currency: 'USD', currencyDisplay:'code'}) -> "USD 1,000.00"

(1000).toLocaleString('en-GB', {style: 'currency', currency: 'USD', currencyDisplay:'symbol'}) -> "US$1,000.00"

[petebacondarwin]

It does appear that we should modify our logic for applying the currency symbol. See https://unicode.org/reports/tr35/tr35-numbers.html#Currencies. I don't fully understand what is written there but it implies to me that this is a confirmed bug.

From what I read we need to be ale to apply rules generated from sections like :

        "currencyFormats-numberSystem-latn": {
          "currencySpacing": {
            "beforeCurrency": {
              "currencyMatch": "[:^S:]",
              "surroundingMatch": "[:digit:]",
              "insertBetween": " "
            },
            "afterCurrency": {
              "currencyMatch": "[:^S:]",
              "surroundingMatch": "[:digit:]",
              "insertBetween": " "
            }
          },

in numbers.json of the cldr-json file.

For reference the S in the currencyMatch refers to a "Symbol". See https://www.unicode.org/reports/tr18/#General_Category_Property and https://www.compart.com/en/unicode/category/Sc

I think we could something with preparing the data into JS regular-expressions to avoid unwanted performance loss.

[DwieDima]

There is also missing whitespace between the currency code and amount when the amount is negative:

When amount is positive it displays the result as expected:

[JeanMeche]

One way to fix this would be to rely on the Intl api.

This is what is proposed in #49143