feat(common): Add an`Intl` implementation for the i18n sub-system. #55283

JeanMeche · 2024-04-10T14:40:21Z

Angular's i18n subsystem is responsible for providing localised formatting of numbers, percents, percentages and dates.
This feature replaces the default implementation of the i18N subsystem.

The commits add a new implementation that relies on the platform-provided Intl API.

With this new implementation relying on a platform API, it is not necessary anymore the load locale files (See #20487) .

The new implementation is available via an opt-in : useIntlImplementation().

This feature fixes the following issues:

Closes #54470

packages/core/src/i18n/locale_data_api.ts

…tation for Date formatting angular#55283 introduced an Intl implementation for the i18n sub-system. For dates, the change might be considered breaking. This migration schematics aims to migrate every existing app, to opt-out of the new `Intl` based implementation to smooth out the transition to the new implementation. A TODO is added to invite developers to try-out themselves the new implementation.

Ahead of angular#55283 and with what we learned from it, let's improve our test coverage on the i18n subsystem.

Ahead of #55283 and with what we learned from it, let's improve our test coverage on the i18n subsystem. PR Close #55532

devversion

Review of currency formatting + plural

devversion · 2024-05-03T10:08:41Z

packages/common/test/pipes/number_pipe_spec.ts

-
-  afterAll(() => ɵunregisterLocaleData());
+// Following ignore is to ease the review of the diff
+// prettier-ignore


Is there a follow-up to remove this?

I'll fix the formatting once the PR is merge.

packages/common/src/i18n/format_number.ts

goldens/public-api/common/index.md

packages/common/test/i18n/format_number_spec.ts

packages/common/src/i18n/intl_helpers.ts

devversion · 2024-05-03T11:23:54Z

packages/core/src/i18n/locale_data_api.ts

@@ -90,18 +92,21 @@ export function getLocaleCurrencyCode(locale: string): string|null {
 * @see {@link NgPlural}
 * @see [Internationalization (i18n) Guide](guide/i18n)
 */
-export function getLocalePluralCase(locale: string): (value: number) => number {
-  const data = findLocaleData(locale);
-  return data[LocaleDataIndex.PluralCase];


Is this a breaking change? i.e. there isn't even a way to get back to legacy CLDR here AFAICT

TGP returned green for this.

Here is the support form Intl.PluralRules.supportedLocalesOf, it is widely within the scope of our supported browser versions.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/PluralRules/supportedLocalesOf

Depending on how strict we are on our breaking change policy, I can be considered breaking or non-breaking. Happy to know what you (and others) think about this.

Does Google3 actually use the CLDR plural data? I don't know off hand.

…nd currencies This commit adds an `Intl` implementation to format numbers, percents and currencies. The implementation is based on the `Intl` API and allows to drop the static imports for the locale date files. fixes angular#33803

With this commit, plurals formatting does not depend on the CLDR locale data anymore.

With this commit, the Intl implementation because the default one and doesn't require the CLDR locale data imports anymore. Opt-out is possible by invoking `useLegacyDateFormatting()` ahead of bootstrap. BREAKING CHANGE: Some custom date format aren't supported any more (`cccccc`, `EEEEEE`, `aaaaa`, `b` to `bbbbb` and `B` to `BBBBB`) The `DatePipe` will not support offset timezone anymore, use IANA timezones instead .

angular-robot bot added the detected: feature PR contains a feature commit label Apr 10, 2024

JeanMeche force-pushed the poc-intl-date branch 2 times, most recently from 6c939c3 to 0ceb875 Compare April 10, 2024 15:02

angular-robot bot added the detected: deprecation PR contains a commit with a deprecation label Apr 10, 2024

JeanMeche changed the title ~~feat(common): Add support for i18N using the Intl API~~ feat(common): Add and enable the Intl implementation for the i18n sub-system. Apr 10, 2024

alan-agius4 reviewed Apr 10, 2024

View reviewed changes

packages/core/src/i18n/locale_data_api.ts Outdated Show resolved Hide resolved

JeanMeche force-pushed the poc-intl-date branch from 0ceb875 to 7c177e2 Compare April 10, 2024 15:21

JeanMeche changed the title ~~feat(common): Add and enable the Intl implementation for the i18n sub-system.~~ feat(common): Add and enable the Intl implementation for the i18n sub-system. Apr 10, 2024

JeanMeche added feature Issue that requests a new feature breaking changes area: i18n and removed detected: feature PR contains a feature commit labels Apr 11, 2024

ngbot bot added this to the Backlog milestone Apr 11, 2024

JeanMeche added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 11, 2024

angular-robot bot added the detected: feature PR contains a feature commit label Apr 11, 2024

JeanMeche modified the milestones: Backlog, v18 feature freeze candidates Apr 11, 2024

alxhub self-assigned this Apr 11, 2024

JeanMeche force-pushed the poc-intl-date branch from f270b14 to d5c6da5 Compare April 12, 2024 09:49

angular-robot bot added the detected: breaking change PR contains a commit with a breaking change label Apr 12, 2024

JeanMeche force-pushed the poc-intl-date branch 2 times, most recently from 767753e to 1ca64d6 Compare April 12, 2024 10:27

JeanMeche marked this pull request as ready for review April 12, 2024 10:42

pullapprove bot requested review from AndrewKushnir and atscott April 12, 2024 10:42

JeanMeche mentioned this pull request Apr 16, 2024

refactor(core): Add schematics to opt-out of theIntl based implemen… #55355

Closed

JeanMeche force-pushed the poc-intl-date branch from 1ca64d6 to ac18c25 Compare April 18, 2024 08:56

angular-robot bot removed the detected: breaking change PR contains a commit with a breaking change label Apr 18, 2024

JeanMeche force-pushed the poc-intl-date branch from 722eb2d to 8a8c659 Compare April 18, 2024 09:48

JeanMeche force-pushed the poc-intl-date branch from 5492c02 to a31b351 Compare April 25, 2024 12:05

angular-robot bot removed the detected: deprecation PR contains a commit with a deprecation label Apr 25, 2024

JeanMeche changed the title ~~feat(common): Add and enable the Intl implementation for the i18n sub-system.~~ feat(common): Add anIntl implementation for the i18n sub-system. Apr 25, 2024

JeanMeche added the target: minor This PR is targeted for the next minor release label Apr 25, 2024

JeanMeche force-pushed the poc-intl-date branch from a31b351 to c493b53 Compare April 25, 2024 12:35

angular-robot bot removed the detected: breaking change PR contains a commit with a breaking change label Apr 25, 2024

JeanMeche added a commit to JeanMeche/angular that referenced this pull request Apr 25, 2024

refactor(common): increment test coverage

bd7d527

Ahead of angular#55283 and with what we learned from it, let's improve our test coverage on the i18n subsystem.

JeanMeche mentioned this pull request Apr 25, 2024

refactor(common): increment test coverage #55532

Closed

AndrewKushnir pushed a commit that referenced this pull request Apr 25, 2024

refactor(common): increment test coverage (#55532)

75db462

Ahead of #55283 and with what we learned from it, let's improve our test coverage on the i18n subsystem. PR Close #55532

AndrewKushnir pushed a commit that referenced this pull request Apr 25, 2024

refactor(common): increment test coverage (#55532)

5926bf4

Ahead of #55283 and with what we learned from it, let's improve our test coverage on the i18n subsystem. PR Close #55532

AndrewKushnir pushed a commit that referenced this pull request Apr 25, 2024

refactor(common): increment test coverage (#55532)

516e5b5

Ahead of #55283 and with what we learned from it, let's improve our test coverage on the i18n subsystem. PR Close #55532

JeanMeche force-pushed the poc-intl-date branch from c493b53 to 0fd1e55 Compare April 25, 2024 20:07

angular-robot bot added the detected: breaking change PR contains a commit with a breaking change label Apr 25, 2024

JeanMeche force-pushed the poc-intl-date branch 2 times, most recently from 6d1e085 to b37e564 Compare April 25, 2024 20:56

devversion reviewed May 3, 2024

View reviewed changes

JeanMeche force-pushed the poc-intl-date branch 3 times, most recently from 57687bb to 51ed5fe Compare May 5, 2024 13:50

JeanMeche added 2 commits May 8, 2024 01:14

feat(common): use the Intl API to for plurals

8fc4c5b

With this commit, plurals formatting does not depend on the CLDR locale data anymore.

JeanMeche force-pushed the poc-intl-date branch 2 times, most recently from 30a12e6 to 344b8d2 Compare May 8, 2024 00:16

JeanMeche force-pushed the poc-intl-date branch from 344b8d2 to 42b4fa9 Compare May 8, 2024 00:55

angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label May 8, 2024

JeanMeche force-pushed the poc-intl-date branch 3 times, most recently from 323772d to 42b4fa9 Compare May 9, 2024 18:33

angular-robot bot removed the area: build & ci Related the build and CI infrastructure of the project label May 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(common): Add an`Intl` implementation for the i18n sub-system. #55283

feat(common): Add an`Intl` implementation for the i18n sub-system. #55283

JeanMeche commented Apr 10, 2024 •

edited

devversion left a comment

devversion May 3, 2024

JeanMeche May 5, 2024

devversion May 3, 2024

JeanMeche May 5, 2024 •

edited

devversion May 7, 2024

feat(common): Add anIntl implementation for the i18n sub-system. #55283

Are you sure you want to change the base?

feat(common): Add anIntl implementation for the i18n sub-system. #55283

Conversation

JeanMeche commented Apr 10, 2024 • edited

devversion left a comment

Choose a reason for hiding this comment

devversion May 3, 2024

Choose a reason for hiding this comment

JeanMeche May 5, 2024

Choose a reason for hiding this comment

devversion May 3, 2024

Choose a reason for hiding this comment

JeanMeche May 5, 2024 • edited

Choose a reason for hiding this comment

devversion May 7, 2024

Choose a reason for hiding this comment

feat(common): Add an`Intl` implementation for the i18n sub-system. #55283

feat(common): Add an`Intl` implementation for the i18n sub-system. #55283

JeanMeche commented Apr 10, 2024 •

edited

JeanMeche May 5, 2024 •

edited