Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add missing tests for comparing observables #34398

Closed
sonukapoor opened this issue Dec 13, 2019 · 7 comments
Closed

docs: Add missing tests for comparing observables #34398

sonukapoor opened this issue Dec 13, 2019 · 7 comments
Labels
feature: insufficient votes Label to add when the not a sufficient number of votes or comments from unique authors feature: votes required Feature request which is currently still in the voting phase feature Issue that requests a new feature freq1: low P4 A relatively minor issue that is not relevant to core functions state: community Someone from the Angular community is working on this issue or submitted this PR
Milestone

Comments

@sonukapoor
Copy link
Contributor

sonukapoor commented Dec 13, 2019

馃摎 Docs or angular.io bug report

Description

The examples used in the comparing-observables guide have no tests ensuring they are valid. Work can start after #34327 has been merged.

What's the affected URL?**

https://angular.io/guide/comparing-observables

@sonukapoor
Copy link
Contributor Author

I will be working on this as soon as the other PR is in place.

@ngbot ngbot bot added this to the needsTriage milestone Dec 13, 2019
@kapunahelewong kapunahelewong added freq1: low severity1: confusing feature Issue that requests a new feature labels Dec 13, 2019
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Dec 13, 2019
@kapunahelewong kapunahelewong added the state: community Someone from the Angular community is working on this issue or submitted this PR label Dec 13, 2019
@kapunahelewong
Copy link
Contributor

This is wonderful! 馃帀Thank you so much, @sonukapoor! If you need anything while working on the PR, feel free to tag me.

@kapunahelewong kapunahelewong added this to Pending - Top of backlog in docs Dec 13, 2019
@gkalpak gkalpak added this to BACKLOG in docs-infra Dec 14, 2019
@gkalpak
Copy link
Member

gkalpak commented Dec 14, 2019

FYI: I moved this to comp: docs-infra, because this is about adding tests for the examples (and the necessary infrastructure changes to accomodate that).

@jelbourn jelbourn added P4 A relatively minor issue that is not relevant to core functions and removed severity1: confusing labels Oct 1, 2020
@angular-robot angular-robot bot added the feature: votes required Feature request which is currently still in the voting phase label Jun 4, 2021
@angular-robot
Copy link
Contributor

angular-robot bot commented Jun 4, 2021

Just a heads up that we kicked off a community voting process for your feature request. There are 20 days until the voting process ends.

Find more details about Angular's feature request process in our documentation.

@angular-robot
Copy link
Contributor

angular-robot bot commented Jun 26, 2021

Thank you for submitting your feature request! Looks like during the polling process it didn't collect a sufficient number of votes to move to the next stage.

We want to keep Angular rich and ergonomic and at the same time be mindful about its scope and learning journey. If you think your request could live outside Angular's scope, we'd encourage you to collaborate with the community on publishing it as an open source package.

You can find more details about the feature request process in our documentation.

@angular-robot angular-robot bot added the feature: insufficient votes Label to add when the not a sufficient number of votes or comments from unique authors label Jun 26, 2021
@gkalpak
Copy link
Member

gkalpak commented Jul 16, 2021

This has been addressed in #34537.

@gkalpak gkalpak closed this as completed Jul 16, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature: insufficient votes Label to add when the not a sufficient number of votes or comments from unique authors feature: votes required Feature request which is currently still in the voting phase feature Issue that requests a new feature freq1: low P4 A relatively minor issue that is not relevant to core functions state: community Someone from the Angular community is working on this issue or submitted this PR
Projects
docs
Pending - Top of backlog
docs-infra
BACKLOG
Development

No branches or pull requests

5 participants