test(docs-infra): add missing tests for observables and promises #34537

sonukapoor · 2019-12-22T23:27:35Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Issue Number: #34398

Does this PR introduce a breaking change?

Yes
No

gkalpak · 2019-12-23T08:15:26Z

Marking this as blocked on #34327, since it builds on top of that.

sonukapoor · 2020-01-22T01:52:59Z

Marking this as blocked on #34327, since it builds on top of that.

@gkalpak This is unblocked now since #34327 has been merged. Can you review it please?

gkalpak

Thx, @sonukapoor ❤️
I've left some comments. Also, the current commit message ("tests for observables and promises") is too generic. Can you, please, change it to be more specific. E.g. something like:

test(docs-infra): add tests for `comparing-observables` example

aio/content/examples/comparing-observables/src/promises.ts

aio/content/examples/comparing-observables/src/observables.ts

gkalpak · 2020-01-23T17:42:52Z

I, also, just realized that we need to make sure the tests are run on CI (currently they are not afaict) 😁

gkalpak

Just few more (minor) comments to go 😃

Also, as mentioned in #34537 (comment), we need to run these tests on CI. This is similar to what you did for other Observables-related examples in #34063. I.e. you need to:

Add a dummy e2e/src/app.e2e-spec.ts (e.g. similar to observables/e2e/src/app.e2e-spec.ts).
Add an appropriate example-config.json (e.g. similar to observables/example-config.json but specifying a different command that actually runs the unit tests).

aio/content/examples/comparing-observables/src/promises.ts

aio/content/examples/comparing-observables/src/promises.spec.ts

aio/content/examples/comparing-observables/src/observables.ts

aio/content/examples/comparing-observables/src/observables.spec.ts

sonukapoor · 2020-01-25T20:04:07Z

Just few more (minor) comments to go 😃

Also, as mentioned in #34537 (comment), we need to run these tests on CI. This is similar to what you did for other Observables-related examples in #34063. I.e. you need to:

Add a dummy e2e/src/app.e2e-spec.ts (e.g. similar to observables/e2e/src/app.e2e-spec.ts).

Add an appropriate example-config.json (e.g. similar to observables/example-config.json but specifying a different command that actually runs the unit tests).

Yes, I haven't gotten to that yet. I wanted to make sure that we are happy with the codebase now. I should be able to look into the testing from CI next.

mary-poppins · 2020-01-26T00:24:40Z

You can preview a5231d7 at https://pr34537-a5231d7.ngbuilds.io/.

mary-poppins · 2020-01-26T00:50:27Z

You can preview d2bd1cc at https://pr34537-d2bd1cc.ngbuilds.io/.

mary-poppins · 2020-08-27T12:19:53Z

You can preview f3bd82e at https://pr34537-f3bd82e.ngbuilds.io/.

mary-poppins · 2020-08-27T12:36:23Z

You can preview c265a4f at https://pr34537-c265a4f.ngbuilds.io/.

This commit adds missing tests for obserables and promises which are both stand-alone mini-apps.

This commit adds the necessary custom commands to run the tests in a node environment.

aio/content/examples/comparing-observables/src/promises.spec.ts

mary-poppins · 2020-08-27T14:29:33Z

You can preview e25f686 at https://pr34537-e25f686.ngbuilds.io/.

mary-poppins · 2020-08-27T14:42:11Z

You can preview ec9406f at https://pr34537-ec9406f.ngbuilds.io/.

gkalpak

Nice job, @sonukapoor! Thx 👍

Reviewed-for: global-docs-approvers

This commit adds missing tests for obserables and promises which are both stand-alone mini-apps. PR Close #34537

This commit adds the necessary custom commands to run the tests in a node environment. PR Close #34537

…lar#34537) This commit adds missing tests for obserables and promises which are both stand-alone mini-apps. PR Close angular#34537

This commit adds the necessary custom commands to run the tests in a node environment. PR Close angular#34537

…#34537)" This reverts commit e8793c2.

…es (angular#34537)" This reverts commit f4c9134.

…lar#34537) This commit adds missing tests for obserables and promises which are both stand-alone mini-apps. PR Close angular#34537

This commit adds the necessary custom commands to run the tests in a node environment. PR Close angular#34537

…lar#34537) This commit adds missing tests for obserables and promises which are both stand-alone mini-apps. PR Close angular#34537

This commit adds the necessary custom commands to run the tests in a node environment. PR Close angular#34537

angular-automatic-lock-bot · 2020-09-27T16:20:56Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

sonukapoor requested review from IgorMinar and a team as code owners December 22, 2019 23:27

googlebot added the cla: yes label Dec 22, 2019

gkalpak added comp: docs-infra action: review The PR is still awaiting reviews from at least one requested reviewer state: blocked target: patch This PR is targeted for the next patch release labels Dec 23, 2019

ngbot bot modified the milestone: needsTriage Dec 23, 2019

sonukapoor force-pushed the tests-for-observables branch from 3eb2e21 to 583ad7f Compare January 22, 2020 01:50

sonukapoor requested a review from a team as a code owner January 22, 2020 01:50

sonukapoor force-pushed the tests-for-observables branch from 583ad7f to aa9a17b Compare January 22, 2020 02:12

gkalpak changed the title ~~Tests for observables~~ test(docs-infra): add missing tests for obserables and promises Jan 22, 2020

gkalpak removed the state: blocked label Jan 22, 2020

gkalpak requested changes Jan 22, 2020

View reviewed changes

gkalpak added the aio: preview label Jan 24, 2020

gkalpak requested changes Jan 25, 2020

View reviewed changes

sonukapoor force-pushed the tests-for-observables branch from f450f03 to d902c0d Compare January 25, 2020 22:47

sonukapoor requested a review from a team as a code owner January 25, 2020 22:47

sonukapoor force-pushed the tests-for-observables branch 4 times, most recently from 232d2e0 to a5231d7 Compare January 26, 2020 00:14

sonukapoor force-pushed the tests-for-observables branch from d2bd1cc to 98a1e73 Compare January 26, 2020 01:37

sonukapoor force-pushed the tests-for-observables branch from f3bd82e to c265a4f Compare August 27, 2020 12:23

sonukapoor force-pushed the tests-for-observables branch from c265a4f to f9cc5b7 Compare August 27, 2020 14:18

sonukapoor added 2 commits August 27, 2020 10:18

test(docs-infra): add missing tests for obserables and promises

cc8ad7b

This commit adds missing tests for obserables and promises which are both stand-alone mini-apps.

test(docs-infra): add commands to run the unit tests

e25f686

This commit adds the necessary custom commands to run the tests in a node environment.

sonukapoor force-pushed the tests-for-observables branch from f9cc5b7 to e25f686 Compare August 27, 2020 14:19

gkalpak requested changes Aug 27, 2020

View reviewed changes

aio/content/examples/comparing-observables/src/promises.spec.ts Outdated Show resolved Hide resolved

fixup! test(docs-infra): add missing tests for obserables and promises

ec9406f

sonukapoor requested a review from gkalpak August 27, 2020 15:27

gkalpak approved these changes Aug 27, 2020

View reviewed changes

gkalpak removed the request for review from alxhub August 27, 2020 15:29

gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Aug 27, 2020

josephperrott pushed a commit that referenced this pull request Aug 27, 2020

test(docs-infra): add missing tests for obserables and promises (#34537)

1b440e8

This commit adds missing tests for obserables and promises which are both stand-alone mini-apps. PR Close #34537

josephperrott pushed a commit that referenced this pull request Aug 27, 2020

test(docs-infra): add commands to run the unit tests (#34537)

94fd5c7

This commit adds the necessary custom commands to run the tests in a node environment. PR Close #34537

josephperrott closed this in fedcfec Aug 27, 2020

josephperrott pushed a commit that referenced this pull request Aug 27, 2020

test(docs-infra): add commands to run the unit tests (#34537)

164cd27

This commit adds the necessary custom commands to run the tests in a node environment. PR Close #34537

subratpalhar92 added a commit to SUBRATPALHAR-ALL-JAVASCRIPT/angular that referenced this pull request Aug 31, 2020

Revert "test(docs-infra): add commands to run the unit tests (angular…

1b838d6

…#34537)" This reverts commit e8793c2.

subratpalhar92 added a commit to SUBRATPALHAR-ALL-JAVASCRIPT/angular that referenced this pull request Aug 31, 2020

Revert "test(docs-infra): add missing tests for obserables and promis…

0ac9273

…es (angular#34537)" This reverts commit f4c9134.

profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020

test(docs-infra): add commands to run the unit tests (angular#34537)

ed87fbe

This commit adds the necessary custom commands to run the tests in a node environment. PR Close angular#34537

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 27, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(docs-infra): add missing tests for observables and promises #34537

test(docs-infra): add missing tests for observables and promises #34537

sonukapoor commented Dec 22, 2019

gkalpak commented Dec 23, 2019

sonukapoor commented Jan 22, 2020

gkalpak left a comment

gkalpak commented Jan 23, 2020

gkalpak left a comment

sonukapoor commented Jan 25, 2020

mary-poppins commented Jan 26, 2020

mary-poppins commented Jan 26, 2020

mary-poppins commented Aug 27, 2020

mary-poppins commented Aug 27, 2020

mary-poppins commented Aug 27, 2020

mary-poppins commented Aug 27, 2020

gkalpak left a comment

angular-automatic-lock-bot bot commented Sep 27, 2020

test(docs-infra): add missing tests for observables and promises #34537

test(docs-infra): add missing tests for observables and promises #34537

Conversation

sonukapoor commented Dec 22, 2019

PR Checklist

PR Type

What is the current behavior?

Does this PR introduce a breaking change?

gkalpak commented Dec 23, 2019

sonukapoor commented Jan 22, 2020

gkalpak left a comment

Choose a reason for hiding this comment

gkalpak commented Jan 23, 2020

gkalpak left a comment

Choose a reason for hiding this comment

sonukapoor commented Jan 25, 2020

mary-poppins commented Jan 26, 2020

mary-poppins commented Jan 26, 2020

mary-poppins commented Aug 27, 2020

mary-poppins commented Aug 27, 2020

mary-poppins commented Aug 27, 2020

mary-poppins commented Aug 27, 2020

gkalpak left a comment

Choose a reason for hiding this comment

angular-automatic-lock-bot bot commented Sep 27, 2020