fix(bazel): do not use manifest paths for generated imports within compilation unit #35841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
force-pushed
the
fix/bazel-ng-package-generated-imports
branch
2 times, most recently
from
36ba941
to
fe1fe4b
Compare
devversion
added
area: bazel
gregmagolan
approved these changes
Mar 3, 2020
|
Yep. Totally agreed. And yes! I'm waiting for that to happen. The current system is too complicated. I tried to improve this by adding comments. Also the fact that we rely on summaries, but not on metadata files, makes ngc-wrapped even more complicated. |
kyliau
approved these changes
Mar 3, 2020
devversion
force-pushed
the
fix/bazel-ng-package-generated-imports
branch
from
fe1fe4b
to
38df841
Compare
devversion
force-pushed
the
fix/bazel-ng-package-generated-imports
branch
from
38df841
to
531cc12
Compare
devversion
force-pushed
the
fix/bazel-ng-package-generated-imports
branch
from
531cc12
to
3d6ecfb
Compare
…mpilation unit Currently, the `ng_module` rule incorrectly uses manifest paths for generated imports from the Angular compiler. This breaks packaging as prodmode output (i.e. `esnext`) is copied in various targets (`es5` and `es2015`) to the npm package output. e.g. imports are generated like: _node_modules/my-pkg/es2015/imports/public-api.js_ ```ts import * as i1 from "angular/packages/bazel/test/ng_package/example/imports/second"; ``` while it should be actually: ```ts import * as i1 from "./second"; ``` The imports can, and should be relative so that the files are self-contained and do not rely on custom module resolution.
devversion
force-pushed
the
fix/bazel-ng-package-generated-imports
branch
from
3d6ecfb
to
36a09a2
Compare
devversion
changed the title
gkalpak
approved these changes
Mar 6, 2020
devversion
added
action: merge
matsko
pushed a commit
that referenced
this pull request
Mar 6, 2020
…mpilation unit (#35841) Currently, the `ng_module` rule incorrectly uses manifest paths for generated imports from the Angular compiler. This breaks packaging as prodmode output (i.e. `esnext`) is copied in various targets (`es5` and `es2015`) to the npm package output. e.g. imports are generated like: _node_modules/my-pkg/es2015/imports/public-api.js_ ```ts import * as i1 from "angular/packages/bazel/test/ng_package/example/imports/second"; ``` while it should be actually: ```ts import * as i1 from "./second"; ``` The imports can, and should be relative so that the files are self-contained and do not rely on custom module resolution. PR Close #35841
matsko
pushed a commit
that referenced
this pull request
Mar 6, 2020
matsko
pushed a commit
that referenced
this pull request
Mar 6, 2020
…mpilation unit (#35841) Currently, the `ng_module` rule incorrectly uses manifest paths for generated imports from the Angular compiler. This breaks packaging as prodmode output (i.e. `esnext`) is copied in various targets (`es5` and `es2015`) to the npm package output. e.g. imports are generated like: _node_modules/my-pkg/es2015/imports/public-api.js_ ```ts import * as i1 from "angular/packages/bazel/test/ng_package/example/imports/second"; ``` while it should be actually: ```ts import * as i1 from "./second"; ``` The imports can, and should be relative so that the files are self-contained and do not rely on custom module resolution. PR Close #35841
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
ng_modulerule incorrectly uses manifest paths forgenerated imports from the Angular compiler.
This breaks packaging as prodmode output (i.e.
esnext) is copied invarious targets (
es5andes2015) to the npm package output. Example:node_modules/my-pkg/es2015/imports/public-api.js
The above import is invalid in NPM and leaks information about the source project
structure. The import should be relative:
The imports can, and should be relative so that the files of the same compilation unit are self-contained and do not rely on custom module resolution.