Dart transformer ChangeDetectors do not have IDs

[mhevery]

When running WTF in Dart with transformers all ChangeDetector ids are null. The issue is here the this.id is null, it seems that ids are not generated in transformer mode. This makes it hard to do debugging.

[mhevery]

/cc @kegluneq This is blocking getting proper traces in WTF for GT/AWS.

[kegluneq]

I'll take a look right away

[kegluneq]

/cc @tbosch , @vsavkin

The change detector ids are coming from ChangeDetectorDefinition, which comes from ProtoViewFactory.

Any idea why these might be coming back empty?

[kegluneq]

@mhevery can you (or someone else) post some repro steps? I haven't been able to get this to happen so far.

[mhevery]

https://travis-ci.org/angular/angular/builds/76371907

[mhevery]

@kegluneq the build is failing with some unrelated error. Could you have a look as to why?
error: https://travis-ci.org/angular/angular/jobs/76371909#L1113
on liner change: 3d237ab

rerun many times the failure is consistent.

[kegluneq]

/cc @rkirov, @vicb

@mhevery , this is coming from package:di

Transform InjectorGenerator on benchmarks_external|web/src/naive_infinite_scroll/index.dart threw error: <rethrow>
Caused by The null object does not have a getter 'importsAndExports'.

Here is InjectorGenerator

That transformer tries to resolve, and the error is cropping up in analyzer. Here is the getter I'm guessing we're trying to call.

Sorry I don't have more here, but I'm flying to MD tomorrow and will be OOO until Tuesday - hopefully someone with more di knowledge can track down the issue.

[vicb]

The failure was related to #3698 which has been reverted from master for now.

Edit: it actually was not related to the router PR, see #3757 instead

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}