Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot compile browser_tree with type checking on. #4507

Closed
alexeagle opened this issue Oct 4, 2015 · 2 comments
Closed

Cannot compile browser_tree with type checking on. #4507

alexeagle opened this issue Oct 4, 2015 · 2 comments
Labels
area: packaging Issues related to Angular's creation of npm packages effort2: days type: bug/fix
Milestone
alpha-39

Comments

@alexeagle
Copy link
Contributor

@vsavkin accidentally turned off our type checking for the non-cjs tree.
I'm turning it back on, but it fails because of
upgrade/typings/jquery/jquery.d.ts (3186, 13): Subsequent variable declarations must have the same type. Variable '$' must be of type 'cssSelectorHelper', but here has type 'JQueryStatic'.
The reason is well-known and documented at DefinitelyTyped/DefinitelyTyped#2734 : Both JQuery and Selenium define a runtime variable in the global scope named $ so the typings files jquery.d.ts and angular-protractor.d.ts both define the symbol for the benefit of the type-checker, but with different types.

The right solution is to compile the modules/upgrade separately from the testing code that depends on protractor. This is a non-trivial change to the build.
alexeagle added a commit to alexeagle/angular that referenced this issue Oct 4, 2015
@alexeagle
chore(typings): re-enable type-checking on the browser trees
cf6ce6e 
this was accidentally disabled in angular@5b5d31f
And we have accumulated some typings errors in the meantime.
One thing we did is introduce dependencies with typing conflicts.
See angular#4507
My solution here is to remove the upgrade module from this compilation unit.
alexeagle added a commit to alexeagle/angular that referenced this issue Oct 4, 2015
@alexeagle
chore(typings): re-enable type-checking on the browser trees
859abfe 
this was accidentally disabled in angular@5b5d31f
And we have accumulated some typings errors in the meantime.
One thing we did is introduce dependencies with typing conflicts.
See angular#4507
My solution here is to remove the upgrade module from this compilation unit.
@alexeagle alexeagle mentioned this issue Oct 4, 2015
Closed
alexeagle added a commit to alexeagle/angular that referenced this issue Oct 4, 2015
@alexeagle
chore(typings): re-enable type-checking on the browser trees
8db179f 
this was accidentally disabled in angular@5b5d31f
And we have accumulated some typings errors in the meantime.
One thing we did is introduce dependencies with typing conflicts.
See angular#4507
My solution here is to remove the upgrade module from this compilation unit.
alexeagle added a commit to alexeagle/angular that referenced this issue Oct 4, 2015
@alexeagle
chore(typings): re-enable type-checking on the browser trees
3d51048 
this was accidentally disabled in angular@5b5d31f
And we have accumulated some typings errors in the meantime.
One thing we did is introduce dependencies with typing conflicts.
See angular#4507
My solution here is to remove the upgrade module from this compilation unit.
@todoubaba
Copy link
Contributor

Similar problem when the VS Code project contains both angular2 and jquery, the IDE always uses 'node_modules/angular2/ts/typings/angular-protractor.d.ts' first and complains about the $ sign.

alexeagle added a commit to alexeagle/angular that referenced this issue Oct 4, 2015
@alexeagle
chore(typings): re-enable type-checking on the browser trees
8ecd891 
this was accidentally disabled in angular@5b5d31f
And we have accumulated some typings errors in the meantime.
One thing we did is introduce dependencies with typing conflicts.
See angular#4507
My solution here is to remove the upgrade module from this compilation unit.
alexeagle added a commit to alexeagle/angular that referenced this issue Oct 5, 2015
@alexeagle
chore(typings): re-enable type-checking on the browser trees
ec748eb 
this was accidentally disabled in angular@5b5d31f
And we have accumulated some typings errors in the meantime.
One thing we did is introduce dependencies with typing conflicts.
See angular#4507
My solution here is to remove the upgrade module from this compilation unit.
alexeagle added a commit to alexeagle/angular that referenced this issue Oct 5, 2015
@alexeagle
chore(typings): re-enable type-checking on the browser trees
f21bd66 
this was accidentally disabled in angular@5b5d31f
And we have accumulated some typings errors in the meantime.
One thing we did is introduce dependencies with typing conflicts.
See angular#4507
My solution here is to remove the upgrade module from this compilation unit.
alexeagle added a commit to alexeagle/angular that referenced this issue Oct 5, 2015
@alexeagle
chore(typings): re-enable type-checking on the browser trees
b2fab70 
this was accidentally disabled in angular@5b5d31f
And we have accumulated some typings errors in the meantime.
One thing we did is introduce dependencies with typing conflicts.
See angular#4507
My solution here is to remove the upgrade module from this compilation unit.
@mhevery mhevery added P1: urgent area: packaging Issues related to Angular's creation of npm packages effort2: days type: bug/fix labels Oct 5, 2015
@IgorMinar IgorMinar added this to the alpha-39 milestone Oct 5, 2015
alexeagle added a commit to alexeagle/angular that referenced this issue Oct 5, 2015
@alexeagle
chore(typings): re-enable type-checking on the browser trees
a83dab3 
this was accidentally disabled in angular@5b5d31f
And we have accumulated some typings errors in the meantime.
One thing we did is introduce dependencies with typing conflicts.
See angular#4507
My solution here is to remove the upgrade module from this compilation unit.
alexeagle added a commit to alexeagle/angular that referenced this issue Oct 5, 2015
@alexeagle
fix(typings): repair broken typechecks
1a303da 
We had the typechecker disabled by accident, and many problems snuck in

Fixes angular#4507
alexeagle added a commit to alexeagle/angular that referenced this issue Oct 9, 2015
@alexeagle
chore(typings): re-enable type-checking on the browser trees
f207ef2 
this was accidentally disabled in angular@5b5d31f
And we have accumulated some typings errors in the meantime.
One thing we did is introduce dependencies with typing conflicts.
See angular#4507
My solution here is to remove the upgrade module from this compilation unit.
alexeagle added a commit to alexeagle/angular that referenced this issue Oct 9, 2015
@alexeagle
chore(typings): re-enable type-checking on the browser trees
ceea435 
this was accidentally disabled in angular@5b5d31f
And we have accumulated some typings errors in the meantime.
One thing we did is introduce dependencies with typing conflicts.
See angular#4507
My solution here is to remove the upgrade module from this compilation unit.
alexeagle added a commit to alexeagle/angular that referenced this issue Oct 9, 2015
@alexeagle
chore(typings): re-enable type-checking on the browser trees
a445c22 
this was accidentally disabled in angular@5b5d31f
And we have accumulated some typings errors in the meantime.
One thing we did is introduce dependencies with typing conflicts.
See angular#4507
My solution here is to remove the upgrade module from this compilation unit.
alexeagle added a commit to alexeagle/angular that referenced this issue Oct 9, 2015
@alexeagle
chore(typings): re-enable type-checking on the browser trees
67e8413 
this was accidentally disabled in angular@5b5d31f
And we have accumulated some typings errors in the meantime.
One thing we did is introduce dependencies with typing conflicts.
See angular#4507
My solution here is to remove the upgrade module from this compilation unit.
@jessegood jessegood mentioned this issue Oct 14, 2015
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: packaging Issues related to Angular's creation of npm packages effort2: days type: bug/fix
Projects
None yet
Milestone
alpha-39
Development

No branches or pull requests
4 participants
@alexeagle @mhevery @IgorMinar @todoubaba