Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firefox XML formatting is broken #48017

Closed
1 of 2 tasks
v4ssi404 opened this issue Nov 10, 2022 · 2 comments
Closed
1 of 2 tasks

Firefox XML formatting is broken #48017

v4ssi404 opened this issue Nov 10, 2022 · 2 comments
Labels
area: devtools P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Milestone
Backlog

Comments

@v4ssi404
Copy link

Is this a bug report or a feature request?

  • Bug Report
  • Feature Request

Please provide the steps to reproduce the issue [Bug Report only]

Please provide the expected behavior vs the actual behavior you encountered [Bug Report only]

What i get:
XML not formatted

What i expect:
XML formatted

Please provide a screenshot if possible [Bug Report only]

What i get:
Schermata da 2022-11-10 09-37-35

What i expect:
Schermata da 2022-11-10 09-37-51

Please provide the exception or error you saw [Bug Report only]

No response

Is this a browser-specific issue? If so, please specify the device, browser, and version. [Bug Report only]

VirtualBox VM 7.02
OS: Ubuntu 20.04.5 LTS
Firefox 106.0.2 (64 bit)

Description [Feature Request only]

No response

Proposed solution [Feature Request only]

No response

Alternatives considered [Feature Request only]

No response
@ngbot ngbot bot added this to the needsTriage milestone Nov 10, 2022
@JeanMeche
Copy link
Member

JeanMeche commented Nov 10, 2022 •
edited

This happens because ng-validate injects a script into the DOM.

React DevTools had the same issue. They fixed it by checking the content-type before injecting the script.

@JeanMeche JeanMeche mentioned this issue Nov 10, 2022
Closed
11 tasks
JeanMeche added a commit to JeanMeche/angular that referenced this issue Nov 10, 2022
@JeanMeche
fix(devtools): prevent devTools to load when not text/html document a…
67bd011 
…ngular#48017
JeanMeche added a commit to JeanMeche/angular that referenced this issue Nov 10, 2022
@JeanMeche
fix(devtools): prevent devTools to load when not text/html document a…
285b633 
…ngular#48017
JeanMeche added a commit to JeanMeche/angular that referenced this issue Nov 10, 2022
@JeanMeche
fix(devtools): prevent devTools to load when not text/html document a…
a6d123b 
…ngular#48017
JeanMeche added a commit to JeanMeche/angular that referenced this issue Nov 10, 2022
@JeanMeche
fix(devtools): prevent devTools to load when not text/html document a…
b4b7b4a 
…ngular#48017
JeanMeche added a commit to JeanMeche/angular that referenced this issue Nov 10, 2022
@JeanMeche
fix(devtools): prevent devTools to load when not text/html document
cd70397 
On Firefox, Angular DevTools was breaking the XML display because of the script injected
Based on contentType, we won't inject that script anymore

Fixes angular#48017
@alxhub alxhub added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Nov 16, 2022
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Nov 16, 2022
dylhunn pushed a commit that referenced this issue Nov 17, 2022
@JeanMeche @dylhunn
fix(devtools): prevent devTools to load when not text/html document (#…
c7b1cc0 
…48021)

On Firefox, Angular DevTools was breaking the XML display because of the script injected
Based on contentType, we won't inject that script anymore

Fixes #48017

PR Close #48021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 18, 2022
trekladyone pushed a commit to trekladyone/angular that referenced this issue Feb 1, 2023
@JeanMeche @trekladyone
fix(devtools): prevent devTools to load when not text/html document (a…
343fcbd 
…ngular#48021)

On Firefox, Angular DevTools was breaking the XML display because of the script injected
Based on contentType, we won't inject that script anymore

Fixes angular#48017

PR Close angular#48021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: devtools P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

fix(devtools): prevent devTools to load when not text/html document JeanMeche/angular
4 participants
@JoostK @JeanMeche @alxhub @v4ssi404