fix(devtools): prevent devTools to load when not text/html document #48021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanMeche
force-pushed
the
feature/fix-48017
branch
from
df6dffd
to
fb12509
Compare
JeanMeche
force-pushed
the
feature/fix-48017
branch
3 times, most recently
from
a6d123b
to
b4b7b4a
Compare
hexiaokang
approved these changes
Nov 10, 2022
On Firefox, Angular DevTools was breaking the XML display because of the script injected Based on contentType, we won't inject that script anymore Fixes angular#48017
JeanMeche
force-pushed
the
feature/fix-48017
branch
from
b4b7b4a
to
cd70397
Compare
mgechev
requested review from
AleksanderBodurri
and removed request for
twerske and
jessicajaniuk
AleksanderBodurri
approved these changes
Nov 14, 2022
alan-agius4
added
action: merge
|
This PR was merged into the repository by commit f8f8928. |
dylhunn
pushed a commit
that referenced
this pull request
Nov 17, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
trekladyone
pushed a commit
to trekladyone/angular
that referenced
this pull request
Feb 1, 2023
…ngular#48021) On Firefox, Angular DevTools was breaking the XML display because of the script injected Based on contentType, we won't inject that script anymore Fixes angular#48017 PR Close angular#48021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Angular DevTools extension breaks the XML formatting on Firefox.
This happens because a script tag is injected into the DOM even if it's a XML Document.
React DevTools had the same issue. They fixed it by checking the
content-typebefore injecting the script.Fixes #48017
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?