Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExpressionChangedAfterItHasBeenCheckedException does not contain the binding when used with Dart transformers #5245

Closed
vsavkin opened this issue Nov 12, 2015 · 3 comments

Comments

@vsavkin
Copy link
Contributor

vsavkin commented Nov 12, 2015

ExpressionChangedAfterItHasBeenCheckedException should contain the binding that caused a problem. It should also contain the component name which template contains the binding.

This works in JS (dynamic/jit) and Dart (dynamic).

@vsavkin vsavkin added this to the beta-00 milestone Nov 12, 2015
@kegluneq
Copy link

@tbosch

This is a mismatch between how change detectors are being configured in TS vs Dart.

  • In TS, genDebugInfo is always true (the third parameter)
  • In Dart, genDebugInfo is always false

Should these both be set to assertionsEnabled()?

@kegluneq
Copy link

Whoops, silly non-named parameters -- it looks like genDebugInfo is set to assertionsEnabled() in both languages.

Are you certain this is not working when assertionsEnabled() returns true? If it is still failing, please provide repro instructions so I can investigate further.

vsavkin added a commit to vsavkin/angular that referenced this issue Nov 24, 2015
vsavkin added a commit to vsavkin/angular that referenced this issue Nov 24, 2015
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants