Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: code example in 'usage notes' tab is shrunk #52818

Closed
keidachird opened this issue Nov 11, 2023 · 1 comment
Closed

docs: code example in 'usage notes' tab is shrunk #52818

keidachird opened this issue Nov 11, 2023 · 1 comment
Labels
area: adev Angular.dev documentation area: docs-infra Angular.dev application and infrastructure good first issue An issue that is suitable for first-time contributors; often a documentation issue. help wanted An issue that is suitable for a community contributor (based on its complexity/scope). P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent state: has PR
Milestone
Backlog

Comments

@keidachird
Copy link

Describe the problem that you experienced

A code block shrinks on Usage notes tab if there is no other text besides a code block

Enter the URL of the topic with the problem

https://angular.dev/api/router/UrlTree?tab=usage-notes

Describe what you were looking for in the documentation

No response

Describe the actions that led you to experience the problem

Occurs at breakpoint @media (min-width: 1200px) on this selector .adev-header-and-tabs:not(.adev-reference-api-tab)

There is max-width: 80ch set on this selector and looks like this width doesn't affect code inside a code block

Describe what you want to experience that would fix the problem

No response

Add a screenshot if that helps illustrate the problem

On this screenshot you can see that there is no other text on Usage notes tab besides code example and this code block shrinks
image

On this screenshot there is some text besides a code block and it is not shrunk
image

If this problem caused an exception or error, please paste it here

No response

If the problem is browser-specific, please specify the device, OS, browser, and version

No response

Provide any additional information here in as much as detail as you can

No response
dnlrbz pushed a commit to dnlrbz/angular that referenced this issue Nov 11, 2023
fix(docs-infra) code example in 'usage notes' tab is shrunk
8438124 
 - Fixes angular#52818
dnlrbz pushed a commit to dnlrbz/angular that referenced this issue Nov 11, 2023
docs(docs-infra) code example in 'usage notes' tab is shrunk
54ceb70 
fix angular#52818
dnlrbz pushed a commit to dnlrbz/angular that referenced this issue Nov 11, 2023
docs(docs-infra) code example in 'usage notes' tab is shrunk
4440a3c 
Fixes that docs details tabs that are not API reference are shrunk and not have full available width

Fixes angular#52818
dnlrbz pushed a commit to dnlrbz/angular that referenced this issue Nov 11, 2023
fix(docs-infra) code example in 'usage notes' tab is shrunk
1b58792 
Fixes that docs details tabs that are not API reference are shrunk and not have full available width

Fixes angular#52818
@dnlrbz dnlrbz mentioned this issue Nov 11, 2023
Closed
10 tasks
dnlrbz pushed a commit to dnlrbz/angular that referenced this issue Nov 11, 2023
fix(docs-infra) code example in 'usage notes' tab is shrunk
41862d4 
Fixes CSS bug that docs details tabs are shrunk and not have full available width

Fixes angular#52818
dnlrbz pushed a commit to dnlrbz/angular that referenced this issue Nov 11, 2023
fix(docs-infra) code example in 'usage notes' tab is shrunk
9c94fbc 
Fixes CSS bug that docs details tabs are shrunk and not have full available width

Fixes angular#52818
dnlrbz pushed a commit to dnlrbz/angular that referenced this issue Nov 11, 2023
fix(docs-infra) code example in 'usage notes' tab is shrunk
d4b90b2 
Fixes CSS bug that docs detail tabs are shrunk and not have full available width

Fixes angular#52818
@dnlrbz dnlrbz mentioned this issue Nov 11, 2023
Closed
10 tasks
dnlrbz pushed a commit to dnlrbz/angular that referenced this issue Nov 11, 2023
@dnlrbz
fix(docs-infra) code example in 'usage notes' tab is shrunk
71ae165 
Fixes CSS bug that docs detail tabs are shrunk and not have full available width

Fixes angular#52818

Signed-off-by: Daniil Rabizo <danilrabizo97@gmail.com>
dnlrbz added a commit to dnlrbz/angular that referenced this issue Nov 11, 2023
@dnlrbz
fix(docs-infra) code example in 'usage notes' tab is shrunk
e9d4d23 
Fixes CSS bug that docs detail tabs are shrunk and not have full available width

Fixes angular#52818
@pkozlowski-opensource pkozlowski-opensource added the area: adev Angular.dev documentation label Nov 13, 2023
@ngbot ngbot bot added this to the needsTriage milestone Nov 13, 2023
@twerske twerske added area: docs-infra Angular.dev application and infrastructure state: has PR help wanted An issue that is suitable for a community contributor (based on its complexity/scope). good first issue An issue that is suitable for first-time contributors; often a documentation issue. labels Nov 13, 2023
dnlrbz added a commit to dnlrbz/angular that referenced this issue Nov 18, 2023
@dnlrbz
docs(docs-infra) code example in 'usage notes' tab is shrunk
f462b7a 
Fixes CSS bug that docs detail tabs are shrunk and not have full available width

Fixes angular#52818
dnlrbz added a commit to dnlrbz/angular that referenced this issue Nov 18, 2023
@dnlrbz
docs(docs-infra) code example in 'usage notes' tab is shrunk
a94ca28 
Fixes CSS bug that docs detail tabs are shrunk and not have full available width

Fixes angular#52818
@JeanMeche JeanMeche mentioned this issue Nov 23, 2023
Closed
@twerske twerske added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Nov 29, 2023
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Nov 29, 2023
@jessicajaniuk jessicajaniuk assigned JeanMeche and unassigned JeanMeche Jan 25, 2024
vladboisa added a commit to vladboisa/angular that referenced this issue Feb 10, 2024
@vladboisa
docs(docs-infra): fix tab shrinking
7b12173 
Fix a behavior when block shrinks on Usage notes tab

Fixes angular#52818
@vladboisa vladboisa mentioned this issue Feb 10, 2024
Closed
14 tasks
vladboisa added a commit to vladboisa/angular that referenced this issue Feb 11, 2024
@vladboisa
docs(docs-infra): fix tab shrinking
bd3da66 
Fix a behavior when block shrinks on Usage notes tab

Fixes angular#52818
@vladboisa vladboisa mentioned this issue Feb 11, 2024
Closed
14 tasks
vladboisa added a commit to vladboisa/angular that referenced this issue Feb 20, 2024
@vladboisa
docs(docs-infra): fix tab shrinking
83e4a6f 
Fix a behavior when block shrinks on Usage notes tab

Fixes angular#52818
alxhub pushed a commit that referenced this issue Feb 21, 2024
@vladboisa @alxhub
docs(docs-infra): fix tab shrinking (#54380)
926063e 
Fix a behavior when block shrinks on Usage notes tab

Fixes #52818

PR Close #54380
@alxhub alxhub closed this as completed in 024c14f Feb 21, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: adev Angular.dev documentation area: docs-infra Angular.dev application and infrastructure good first issue An issue that is suitable for first-time contributors; often a documentation issue. help wanted An issue that is suitable for a community contributor (based on its complexity/scope). P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent state: has PR
Projects
None yet
Milestone
Backlog
4 participants
@pkozlowski-opensource @JeanMeche @twerske @keidachird