Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs-infra) code example in 'usage notes' tab is shrunk #52820

Closed
wants to merge 1 commit into from

Conversation

dnlrbz
Copy link

@dnlrbz dnlrbz commented Nov 11, 2023

Fixes that docs details tabs that are not API reference are shrunk and not have full available width

Fixes #52818

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • [ x] Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Currently, the non-API tabs in the new docs are shrunk and not taking will available width.

Issue Number: 52818

What is the new behavior?

Docs tabs take full available width, so that example code is visible.

Does this PR introduce a breaking change?

  • Yes
  • [ x] No

Other information

Copy link

google-cla bot commented Nov 11, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Fixes CSS bug that docs details tabs are shrunk and not have full available width

Fixes angular#52818
@dnlrbz dnlrbz marked this pull request as draft November 11, 2023 16:27
@dnlrbz dnlrbz closed this Nov 11, 2023
@dnlrbz dnlrbz deleted the fix/docs-52818 branch November 11, 2023 16:30
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: code example in 'usage notes' tab is shrunk
1 participant