Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): properly report missing DI tokens #9065

Merged
merged 1 commit into from Jun 9, 2016

Conversation

pkozlowski-opensource
Copy link
Member

Fixes #8245

@pkozlowski-opensource
Copy link
Member Author

Hmm, for some reason tests are passing for me locally but not on Travis :-/

It is kind of tricky to write unit tests for this one since we need a situation where a given symbol / type is undefined without making TS complain.... In any case the issue is real and the fix is catching the problematic scenario...

Would appreciate a TS-guru giving me hand with the problematic test here....

@vicb
Copy link
Contributor

vicb commented Jun 7, 2016

@pkozlowski-opensource the issue looks like angular/tsickle#148 - should be solved in next tsickle release

/cc @mprobst

blocked on tscikle

@pkozlowski-opensource
Copy link
Member Author

Thnx @vicb - it does indeed looks like a root cause / blocker.

@pkozlowski-opensource
Copy link
Member Author

Actually we can reproduce the same issue without fiddling with interfaces so it is no longer blocked on tscikle. BrowserStack build is failing but it looks like a flake not related to this PR.

@pkozlowski-opensource pkozlowski-opensource added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jun 9, 2016
@vicb vicb added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 9, 2016
@vicb vicb merged commit 3aca5ff into angular:master Jun 9, 2016
KiaraGrouwstra pushed a commit to KiaraGrouwstra/angular that referenced this pull request Jun 10, 2016
KiaraGrouwstra pushed a commit to KiaraGrouwstra/angular that referenced this pull request Jun 21, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RC.x] Injecting missing import throws Cannot read property query of null
3 participants