New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compiler): properly report missing DI tokens #9065
Conversation
Hmm, for some reason tests are passing for me locally but not on Travis :-/ It is kind of tricky to write unit tests for this one since we need a situation where a given symbol / type is undefined without making TS complain.... In any case the issue is real and the fix is catching the problematic scenario... Would appreciate a TS-guru giving me hand with the problematic test here.... |
@pkozlowski-opensource the issue looks like angular/tsickle#148 - should be solved in next tsickle release /cc @mprobst blocked on tscikle |
Thnx @vicb - it does indeed looks like a root cause / blocker. |
16caa5b
to
7bd0b7b
Compare
Actually we can reproduce the same issue without fiddling with interfaces so it is no longer blocked on tscikle. BrowserStack build is failing but it looks like a flake not related to this PR. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #8245