-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'select' attribute of <ng-content > is completely ignored in Hybrid Mode (UpgradeAdapter) #9643
Comments
youdz
added a commit
to youdz/angular
that referenced
this issue
Jun 29, 2016
- Full use of core Angular 2 projection for downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. - declareNg1Module() and initForNg1Tests() methods on the UpgradeAdapter to allow testing hybrid applications through Angular 1 without having to redeclare the adapter module and recompile every downgraded component for every test. Closes angular#6629, angular#7727, angular#8729, angular#5462, angular#9643, angular#9649
youdz
added a commit
to youdz/angular
that referenced
this issue
Jun 29, 2016
- Full use of core Angular 2 projection for downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. - declareNg1Module() and initForNg1Tests() methods on the UpgradeAdapter to allow testing hybrid applications through Angular 1 without having to redeclare the adapter module and recompile every downgraded component for every test. Closes angular#6629, angular#7727, angular#8729, angular#5462, angular#9643, angular#9649
youdz
added a commit
to youdz/angular
that referenced
this issue
Jun 29, 2016
- Full use of core Angular 2 projection for downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. - declareNg1Module() and initForNg1Tests() methods on the UpgradeAdapter to allow testing hybrid applications through Angular 1 without having to redeclare the adapter module and recompile every downgraded component for every test. Closes angular#6629, angular#7727, angular#8729, angular#5462, angular#9643, angular#9649
I can still reproduce this issue in RC4. Updated plunker to point to RC4 bundles. |
youdz
added a commit
to youdz/angular
that referenced
this issue
Jul 14, 2016
- Full use of core Angular 2 projection for downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. - declareNg1Module() and initForNg1Tests() methods on the UpgradeAdapter to allow testing hybrid applications through Angular 1 without having to redeclare the adapter module and recompile every downgraded component for every test. Closes angular#6629, angular#7727, angular#8729, angular#5462, angular#9643, angular#9649
The linked PR #9538 isn't merged yet and therefore not yet shipped. |
youdz
added a commit
to youdz/angular
that referenced
this issue
Oct 14, 2016
- Full use of core Angular 2 projection for downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. - declareNg1Module() and initForNg1Tests() methods on the UpgradeAdapter to allow testing hybrid applications through Angular 1 without having to redeclare the adapter module and recompile every downgraded component for every test. Closes angular#6629, angular#7727, angular#8729, angular#5462, angular#9643, angular#9649
youdz
added a commit
to youdz/angular
that referenced
this issue
Oct 14, 2016
- Full use of core Angular 2 projection for downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. - declareNg1Module() and initForNg1Tests() methods on the UpgradeAdapter to allow testing hybrid applications through Angular 1 without having to redeclare the adapter module and recompile every downgraded component for every test. Closes angular#6629, angular#7727, angular#8729, angular#5462, angular#9643, angular#9649
youdz
added a commit
to youdz/angular
that referenced
this issue
Oct 14, 2016
- Full use of core Angular 2 projection for downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. - declareNg1Module() and initForNg1Tests() methods on the UpgradeAdapter to allow testing hybrid applications through Angular 1 without having to redeclare the adapter module and recompile every downgraded component for every test. Closes angular#6629, angular#7727, angular#8729, angular#5462, angular#9643, angular#9649
youdz
added a commit
to youdz/angular
that referenced
this issue
Nov 2, 2016
- Full use of core Angular 2 projection for downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. - declareNg1Module() and initForNg1Tests() methods on the UpgradeAdapter to allow testing hybrid applications through Angular 1 without having to redeclare the adapter module and recompile every downgraded component for every test. Closes angular#6629, angular#7727, angular#8729, angular#5462, angular#9643, angular#9649
youdz
added a commit
to youdz/angular
that referenced
this issue
Nov 2, 2016
- Full use of core Angular 2 projection for downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. - declareNg1Module() and initForNg1Tests() methods on the UpgradeAdapter to allow testing hybrid applications through Angular 1 without having to redeclare the adapter module and recompile every downgraded component for every test. Closes angular#6629, angular#7727, angular#8729, angular#5462, angular#9643, angular#9649
petebacondarwin
pushed a commit
to petebacondarwin/angular
that referenced
this issue
Nov 2, 2016
…ance - Full support for content projection in downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Correctly wire up hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. Closes angular#6629, angular#7727, angular#8729, angular#9643, angular#9649
petebacondarwin
added a commit
to petebacondarwin/angular
that referenced
this issue
Nov 3, 2016
… inheritance - Full support for content projection in downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Correctly wire up hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. Closes angular#6629, angular#7727, angular#8729, angular#9643, angular#9649
petebacondarwin
added a commit
to petebacondarwin/angular
that referenced
this issue
Nov 3, 2016
… inheritance - Full support for content projection in downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Correctly wire up hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. Closes angular#6629, angular#7727, angular#8729, angular#9643, angular#9649
petebacondarwin
pushed a commit
to petebacondarwin/angular
that referenced
this issue
Nov 3, 2016
…ance - Full support for content projection in downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Correctly wire up hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. Closes angular#6629, angular#7727, angular#8729, angular#9643, angular#9649
petebacondarwin
added a commit
to petebacondarwin/angular
that referenced
this issue
Nov 3, 2016
…ance - Full support for content projection in downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Correctly wire up hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. Closes angular#6629, angular#7727, angular#8729, angular#9643, angular#9649
petebacondarwin
added a commit
to petebacondarwin/angular
that referenced
this issue
Nov 3, 2016
…ance - Full support for content projection in downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Correctly wire up hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. Closes angular#6629, angular#7727, angular#8729, angular#9643, angular#9649
petebacondarwin
added a commit
to petebacondarwin/angular
that referenced
this issue
Nov 3, 2016
…ance - Full support for content projection in downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Correctly wire up hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. Closes angular#6629, angular#7727, angular#8729, angular#9643, angular#9649
petebacondarwin
pushed a commit
to petebacondarwin/angular
that referenced
this issue
Nov 4, 2016
…ance - Full support for content projection in downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Correctly wire up hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. Closes angular#6629, angular#7727, angular#8729, angular#9643, angular#9649
petebacondarwin
pushed a commit
to petebacondarwin/angular
that referenced
this issue
Nov 17, 2016
…ance - Full support for content projection in downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Correctly wire up hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. Closes angular#6629, angular#7727, angular#8729, angular#9643, angular#9649
petebacondarwin
pushed a commit
to petebacondarwin/angular
that referenced
this issue
Nov 17, 2016
- Full support for content projection in downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Correctly wire up hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. Closes angular#6629, angular#7727, angular#8729, angular#9643, angular#9649
petebacondarwin
pushed a commit
to petebacondarwin/angular
that referenced
this issue
Nov 18, 2016
- Full support for content projection in downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Correctly wire up hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. Closes angular#6629, angular#7727, angular#8729, angular#9643, angular#9649
petebacondarwin
pushed a commit
to petebacondarwin/angular
that referenced
this issue
Nov 18, 2016
- Full support for content projection in downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Correctly wire up hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. Closes angular#6629, angular#7727, angular#8729, angular#9643, angular#9649
petebacondarwin
pushed a commit
to petebacondarwin/angular
that referenced
this issue
Nov 25, 2016
- Full support for content projection in downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Correctly wire up hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. Closes angular#6629, angular#7727, angular#8729, angular#9643, angular#9649
petebacondarwin
pushed a commit
to petebacondarwin/angular
that referenced
this issue
Nov 30, 2016
- Full support for content projection in downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Correctly wire up hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. Closes angular#6629, angular#7727, angular#8729, angular#9643, angular#9649
petebacondarwin
added a commit
to petebacondarwin/angular
that referenced
this issue
Nov 30, 2016
- Full support for content projection in downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Correctly wire up hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. Closes angular#6629, angular#7727, angular#8729, angular#9643, angular#9649
petebacondarwin
added a commit
to petebacondarwin/angular
that referenced
this issue
Nov 30, 2016
- Full support for content projection in downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Correctly wire up hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. Closes angular#6629, angular#7727, angular#8729, angular#9643, angular#9649
petebacondarwin
added a commit
to petebacondarwin/angular
that referenced
this issue
Dec 1, 2016
- Full support for content projection in downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Correctly wire up hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. Closes angular#6629, angular#7727, angular#8729, angular#9643, angular#9649
petebacondarwin
pushed a commit
to petebacondarwin/angular
that referenced
this issue
Dec 1, 2016
- Full support for content projection in downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Correctly wire up hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. Closes angular#6629, angular#7727, angular#8729, angular#9643, angular#9649
petebacondarwin
pushed a commit
to petebacondarwin/angular
that referenced
this issue
Dec 2, 2016
- Full support for content projection in downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Correctly wire up hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. Closes angular#6629, angular#7727, angular#8729, angular#9643, angular#9649, angular#12675
petebacondarwin
pushed a commit
to petebacondarwin/angular
that referenced
this issue
Dec 8, 2016
- Full support for content projection in downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Correctly wire up hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. Closes angular#6629, angular#7727, angular#8729, angular#9643, angular#9649, angular#12675
petebacondarwin
pushed a commit
to petebacondarwin/angular
that referenced
this issue
Dec 8, 2016
- Full support for content projection in downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Correctly wire up hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. Closes angular#6629, angular#7727, angular#8729, angular#9643, angular#9649, angular#12675
petebacondarwin
pushed a commit
to petebacondarwin/angular
that referenced
this issue
Dec 8, 2016
- Full support for content projection in downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Correctly wire up hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. Closes angular#6629, angular#7727, angular#8729, angular#9643, angular#9649, angular#12675
petebacondarwin
added a commit
to petebacondarwin/angular
that referenced
this issue
Dec 10, 2016
fix(upgrade): fix downgrade content projection and injector inheritance - Full support for content projection in downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Correctly wire up hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. Closes angular#6629, angular#7727, angular#8729, angular#9643, angular#9649, angular#12675
petebacondarwin
pushed a commit
to petebacondarwin/angular
that referenced
this issue
Dec 14, 2016
- Full support for content projection in downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Correctly wire up hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. Closes angular#6629, angular#7727, angular#8729, angular#9643, angular#9649, angular#12675
vicb
pushed a commit
that referenced
this issue
Dec 14, 2016
- Full support for content projection in downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Correctly wire up hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. Closes #6629, #7727, #8729, #9643, #9649, #12675
vicb
pushed a commit
that referenced
this issue
Dec 15, 2016
- Full support for content projection in downgraded Angular 2 components. In particular, this enables multi-slot projection and other features on <ng-content>. - Correctly wire up hierarchical injectors for downgraded Angular 2 components: downgraded components inherit the injector of the first other downgraded Angular 2 component they find up the DOM tree. Closes #6629, #7727, #8729, #9643, #9649, #12675
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I'm submitting a ... (check one with "x")
Current behavior
In Hybrid mode (when bootstrapped using upgradeAdatper.bootstrap()), the
<ng-content select ='' >
attribute on the downgraded ng2 component is not honored. it seems that select='' expression is ignored completely and all the light DOM child elements are included.Expected/desired behavior
In Hybrid mode, the
<ng-content select=''>
attribute should be honored and should include only those DOM element matching the 'select' criteria.Reproduction of the problem
Here is the plunker https://plnkr.co/edit/L7Flah?p=preview
What is the expected behavior?
What is the motivation / use case for changing the behavior?
It breaks the desired ng2 component behavior in hybrid mode.
Please tell us about your environment:
Tested in Chrome Version 51.0.2704.103 m
https://code.angularjs.org/tools/typescript.js
The text was updated successfully, but these errors were encountered: