fix(core): do not rethrow an error from ErrorHandler

[DzmitryShylovich]

Closes #13159 and #8993

Issue description:
The origin of the issue is this line. After rethrowing we are getting unsubscribed and do not receive further errors. According to the comment this is required to fail on bootstrap error but I think this is outdated because there're several tests to ensure that bootstrap will fail even if ErrorHandler is not rethrowing the error.

If we still need to rethrow on bootstrap then another solution would be to set rethrowError to false after bootstrap.

[chuckjaz]

This change was reverted.

The refactor done in the last commit broke users who used implements ErrorHandler. The approved change before the last commit does not break implements.

[DzmitryShylovich]

@chuckjaz you mean sub classes won't have access to rethrowError prop?

[chuckjaz]

No. The issue is that we specifically marked it rethrowError as @internal which excludes it from the .d.ts. By removing that and making it private you made implements ErrorHandler an error because private rethrowError shows up in the .d.ts file and makes it so the class cannot be used as an interface.

[DzmitryShylovich]

@chuckjaz hmm sorry. didn't think about that. here's non breaking commit #15077

[chuckjaz]

Thanks! In the future, avoid refactoring after approvals because we run internal tests before we commit. The internal tests succeeded on your previous change but on the refactored change.

[vicb]

avoid refactoring after approvals

probably we should make further changes invalidate approvals

[DzmitryShylovich]

I changed the commit message (according to Igor's guidelines) and decided to simplify the code a bit 😄

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}