Skip to content

Commit

Permalink
Revert "fix(core): ErrorHandler should not rethrow an error by default (
Browse files Browse the repository at this point in the history
angular#13534)"

This reverts commit 1aebea5.
  • Loading branch information
chuckjaz authored and juleskremer committed Aug 24, 2017
1 parent 04edd1a commit 11fef73
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion packages/core/src/error_handler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,12 @@ export class ErrorHandler {
*/
_console: Console = console;

constructor(private rethrowError: boolean = false) {}
/**
* @internal
*/
rethrowError: boolean;

constructor(rethrowError: boolean = true) { this.rethrowError = rethrowError; }

handleError(error: any): void {
this._console.error(`EXCEPTION: ${this._extractMessage(error)}`);
Expand All @@ -66,6 +71,8 @@ export class ErrorHandler {
}
}

// We rethrow exceptions, so operations like 'bootstrap' will result in an error
// when an error happens. If we do not rethrow, bootstrap will always succeed.
if (this.rethrowError) throw error;
}

Expand Down

0 comments on commit 11fef73

Please sign in to comment.