New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typofixes by https://github.com/vlajos/misspell_fixer #16257
Conversation
bd5732d
to
d0a6e3d
Compare
(I have not known this pullapprove system. Let me know please if splitting/reorganising the PR would make the story smoother.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this ❤️
Extra points if you found them by reading through all files 😛
@@ -666,7 +666,7 @@ export class _ParseAST { | |||
} | |||
|
|||
/** | |||
* An identifier, a keyword, a string with an optional `-` inbetween. | |||
* An identifier, a keyword, a string with an optional `-` between. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not in-between
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are right. I reverted this one.
d0a6e3d
to
bfea95d
Compare
An approval from @IgorMinar or @mhevery would cover all necessary groups. |
bfea95d
to
eaa70f6
Compare
2b5a96b
to
eb263aa
Compare
I rebased a few times to fix the conflicts. Can I do anything else, to make the story slicker? |
eb263aa
to
364d16d
Compare
I rebased for you and force pushed that commit into your PR. That took care of the merge conflicts. Requesting @IgorMinar approval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terrific! LGTM. Keep up the good work.
364d16d
to
e75d012
Compare
Can't get this to pass CircleCI because it's trapped in v1. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
Some typos in the code, mostly in documentation blocks.
What is the new behavior?
The typos had been fixed.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: