Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typofixes by https://github.com/vlajos/misspell_fixer #16257

Closed
wants to merge 1 commit into from

Conversation

vlajos
Copy link
Contributor

@vlajos vlajos commented Apr 22, 2017

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ X] Code style update (formatting, local variables)
[ X] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

Some typos in the code, mostly in documentation blocks.

What is the new behavior?

The typos had been fixed.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

  • I am a bit uncertain about the commit message format. Let me know please whether/how should I modify it...
  • And generally I am not too familiar with the rules, let me know please if anything should have to be amended.

@vlajos vlajos force-pushed the typofixes-20170422-vlajos branch 2 times, most recently from bd5732d to d0a6e3d Compare April 22, 2017 21:19
@vlajos
Copy link
Contributor Author

vlajos commented Apr 23, 2017

(I have not known this pullapprove system. Let me know please if splitting/reorganising the PR would make the story smoother.)

Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this ❤️
Extra points if you found them by reading through all files 😛

@@ -666,7 +666,7 @@ export class _ParseAST {
}

/**
* An identifier, a keyword, a string with an optional `-` inbetween.
* An identifier, a keyword, a string with an optional `-` between.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not in-between?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are right. I reverted this one.

@gkalpak
Copy link
Member

gkalpak commented Apr 24, 2017

An approval from @IgorMinar or @mhevery would cover all necessary groups.
But there are also some conflicts to be resolved.

@vlajos vlajos force-pushed the typofixes-20170422-vlajos branch 3 times, most recently from 2b5a96b to eb263aa Compare May 10, 2017 20:27
@vlajos
Copy link
Contributor Author

vlajos commented May 10, 2017

I rebased a few times to fix the conflicts. Can I do anything else, to make the story slicker?

@wardbell wardbell added this to Review in docs Jun 21, 2017
@wardbell wardbell added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jun 22, 2017
@wardbell
Copy link
Contributor

wardbell commented Jun 22, 2017

I rebased for you and force pushed that commit into your PR. That took care of the merge conflicts.
I'm reviewing the changes next while Travis grinds away.

Requesting @IgorMinar approval

Copy link
Contributor

@wardbell wardbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terrific! LGTM. Keep up the good work.

@wardbell wardbell requested a review from IgorMinar June 22, 2017 05:58
@wardbell wardbell added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jun 22, 2017
@wardbell wardbell moved this from Review to API doc in docs Jun 22, 2017
@wardbell
Copy link
Contributor

Can't get this to pass CircleCI because it's trapped in v1.
Created new PR #17716 that contains this commit so you'll still be credited for your fine work.
That PR closes this one.

@wardbell wardbell closed this Jun 23, 2017
@wardbell wardbell removed this from API doc in docs Jun 23, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: review The PR is still awaiting reviews from at least one requested reviewer cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants