fix(compiler): compile .ngfactory.ts files even if nobody reference…
#16899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
approved these changes
May 22, 2017
| @@ -13,39 +13,53 @@ import * as path from 'path'; | |||
|
|
|||
| import {main} from '../src/main'; | |||
|
|
|||
| function getNgRootDir() { | |||
| const moduleFilename = module.filename.replace(/\\/g, '/'); | |||
| const distIndex = moduleFilename.indexOf('/dist/all'); | |||
There was a problem hiding this comment.
maybe throw if you don't find it? this failure will be hard to track down when we change the output layout next time
| ngOptions.basePath = basePath; | ||
| const createProgram = (host: ts.CompilerHost, oldProgram?: ts.Program) => | ||
| ts.createProgram(parsed.fileNames, parsed.options, host, oldProgram); | ||
| let rootFileNames: string[] = parsed.fileNames.slice(0); |
There was a problem hiding this comment.
I think we now prefer splat in a new array
[...parsed.fileNames]
| ts.createProgram(parsed.fileNames, parsed.options, host, oldProgram); | ||
| let rootFileNames: string[] = parsed.fileNames.slice(0); | ||
| const createProgram = (host: ts.CompilerHost, oldProgram?: ts.Program) => { | ||
| return ts.createProgram(rootFileNames.slice(0), parsed.options, host, oldProgram); |
|
|
||
| constructor(private readFile = ts.sys.readFile, private readDirectory = ts.sys.readDirectory) {} | ||
| constructor(private readFile = ts.sys.readFile, private readDirectory = ts.sys.readDirectory) { | ||
| this.parseConfigHost = { |
There was a problem hiding this comment.
can you give this a type now, to avoid typos? looks like we only omitted it due to g3 version skew earlier
There was a problem hiding this comment.
It has one, see the member declaration.
…s them. This is especially important for library authors, as they will not reference the .ngfactory.ts files. Fixes angular#16741
mhevery
approved these changes
May 25, 2017
Merged
3 tasks
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
…s them. (angular#16899) This is especially important for library authors, as they will not reference the .ngfactory.ts files. Fixes angular#16741
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
…s them. (angular#16899) This is especially important for library authors, as they will not reference the .ngfactory.ts files. Fixes angular#16741
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s them.
This is especially important for library authors, as they will
not reference the .ngfactory.ts files.
Fixes #16741
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: