-
Notifications
You must be signed in to change notification settings - Fork 26.5k
Description
Dan B in Ionic slack can give more info if needed
[X] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
**Current behavior**
This exists in Angular 4.1.
If I have a type error in one of my templates, when I run `ngc` against it, it does not detect the error. After generating the `.ngfactory.ts` files, when I run `ngc` again, the error is properly detected.
For example, see building the `ionic-conference-app` demo with an error in a template. The two `ngc` calls are executed one-after-another.
dan at Dans-MacBook-Pro-2 in ~/Desktop/ionic-conference-app (master●)
$ ./node_modules/.bin/ngc
dan at Dans-MacBook-Pro-2 in ~/Desktop/ionic-conference-app (master●●)
$ ./node_modules/.bin/ngc
Error at /Users/dan/Desktop/ionic-conference-app/node_modules/ionic-angular/components/searchbar/searchbar.ngfactory.ts:237:33: Supplied parameters do not match any signature of call target.
Error at /Users/dan/Desktop/ionic-conference-app/node_modules/ionic-angular/components/searchbar/searchbar.ngfactory.ts:241:33: Supplied parameters do not match any signature of call target.
**Expected behavior**
To typecheck code the first time `ngc` is executed.
** Recreation steps **
1. Create a sample project
2. Introduce a typing error in the template
3. run `./node_modules/.bin/ngc` and observe the error in not reported.
4. run `./node_modules/.bin/ngc` again and observe the error is reported.
Thanks,
Dan