Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NGC not type checking .ngfactory files on the first run #16741

Closed
danbucholtz opened this issue May 12, 2017 · 1 comment · Fixed by #16899 or GulajavaMinistudio/angular#57
Closed

NGC not type checking .ngfactory files on the first run #16741

danbucholtz opened this issue May 12, 2017 · 1 comment · Fixed by #16899 or GulajavaMinistudio/angular#57
Labels
area: core Issues related to the framework runtime freq3: high type: bug/fix

Comments

@danbucholtz
Copy link
Contributor

Dan B in Ionic slack can give more info if needed

[X] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question


**Current behavior**

This exists in Angular 4.1.

If I have a type error in one of my templates, when I run `ngc` against it, it does not detect the error. After generating the `.ngfactory.ts` files, when I run `ngc` again, the error is properly detected.

For example, see building the `ionic-conference-app` demo with an error in a template. The two `ngc` calls are executed one-after-another.

dan at Dans-MacBook-Pro-2 in ~/Desktop/ionic-conference-app (master●)
$ ./node_modules/.bin/ngc

dan at Dans-MacBook-Pro-2 in ~/Desktop/ionic-conference-app (master●●)
$ ./node_modules/.bin/ngc
Error at /Users/dan/Desktop/ionic-conference-app/node_modules/ionic-angular/components/searchbar/searchbar.ngfactory.ts:237:33: Supplied parameters do not match any signature of call target.
Error at /Users/dan/Desktop/ionic-conference-app/node_modules/ionic-angular/components/searchbar/searchbar.ngfactory.ts:241:33: Supplied parameters do not match any signature of call target.


**Expected behavior**

To typecheck code the first time `ngc` is executed.

** Recreation steps **
1. Create a sample project
2. Introduce a typing error in the template
3. run `./node_modules/.bin/ngc` and observe the error in not reported.
4. run `./node_modules/.bin/ngc` again and observe the error is reported.



Thanks,
Dan
@jasonaden jasonaden added the area: core Issues related to the framework runtime label May 12, 2017
@tbosch tbosch added this to Prio_col0 in Compiler May 12, 2017
@tbosch tbosch self-assigned this May 19, 2017
tbosch added a commit to tbosch/angular that referenced this issue May 19, 2017
…s them.

This is especially important for library authors, as they will
not reference the .ngfactory.ts files.

Fixes angular#16741
tbosch added a commit to tbosch/angular that referenced this issue May 20, 2017
…s them.

This is especially important for library authors, as they will
not reference the .ngfactory.ts files.

Fixes angular#16741
tbosch added a commit to tbosch/angular that referenced this issue May 22, 2017
…s them.

This is especially important for library authors, as they will
not reference the .ngfactory.ts files.

Fixes angular#16741
tbosch added a commit to tbosch/angular that referenced this issue May 23, 2017
…s them.

This is especially important for library authors, as they will
not reference the .ngfactory.ts files.

Fixes angular#16741
tbosch added a commit to tbosch/angular that referenced this issue May 23, 2017
…s them.

This is especially important for library authors, as they will
not reference the .ngfactory.ts files.

Fixes angular#16741
chuckjaz pushed a commit to chuckjaz/angular that referenced this issue May 25, 2017
…s them. (angular#16899)

This is especially important for library authors, as they will
not reference the .ngfactory.ts files.

Fixes angular#16741
@tbosch tbosch moved this from Prio_col0 to Done in Compiler Jun 15, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this issue Aug 11, 2017
…s them. (angular#16899)

This is especially important for library authors, as they will
not reference the .ngfactory.ts files.

Fixes angular#16741
juleskremer pushed a commit to juleskremer/angular that referenced this issue Aug 28, 2017
…s them. (angular#16899)

This is especially important for library authors, as they will
not reference the .ngfactory.ts files.

Fixes angular#16741
@tbosch tbosch removed this from Done in Compiler Oct 3, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: core Issues related to the framework runtime freq3: high type: bug/fix
Projects
None yet
3 participants