New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of ngc in bazel / blaze #19581

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@tbosch
Member

tbosch commented Oct 5, 2017

No description provided.

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Oct 5, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Oct 5, 2017

perf(compiler): only type check input files when using bazel
This helps hazel as it does not check libraries (e.g. the default lib) which are
not input files, but still checks `.d.ts` files that are inputs.
@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Oct 5, 2017

@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Oct 5, 2017

Show outdated Hide outdated packages/bazel/src/ngc-wrapped/index.ts Outdated
Show outdated Hide outdated packages/bazel/src/ngc-wrapped/index.ts Outdated
perf(compiler): speed up loading of summaries for bazel.
For hazel, we have a specific way of writing summaries,
which we can leverage to make the deserialization faster.
@mary-poppins

This comment has been minimized.

Show comment
Hide comment
@mary-poppins

mary-poppins commented Oct 6, 2017

@tbosch tbosch modified the milestone: Merge-queue Oct 6, 2017

chuckjaz added a commit to chuckjaz/angular that referenced this pull request Oct 6, 2017

perf(compiler): speed up loading of summaries for bazel. (angular#19581)
For hazel, we have a specific way of writing summaries,
which we can leverage to make the deserialization faster.

PR Close angular#19581

@chuckjaz chuckjaz closed this in 0b06ea1 Oct 6, 2017

@tbosch tbosch deleted the tbosch:perf_g3 branch Oct 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment