docs: testing guide for CLI #20697

wardbell · 2017-11-29T20:13:03Z

Update testing guide to reflect CLI usage and current "best practices"
See #19510

updates tests

heavy prose revisions
uses HttpClient (with angular-in-memory-web-api)
test HeroService using HttpClientTestingModule
scrub away most By.css
fake async observable with asyncData()
extensive TwainComponent work
different take on retryWhen
remove app barrels (& systemjs.extras) which troubled plunker/systemjs
add dummy export const to hero.ts (plunkr/systemjs fails w/o it)
shrink and re-organize TOC
add marble testing package and tests
demonstrate the "no beforeEach()" test coding style
add section on HTTP service testing
prepare for stackblitz PR build(aio): migrate plunker to stackblitz #20165
make it work in plunker except excluded marble test

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes 
[ ] Other... Please describe:

mary-poppins · 2017-11-29T20:28:10Z

You can preview a14e2b6 at https://pr20697-a14e2b6.ngbuilds.io/.

mary-poppins · 2017-12-01T01:36:19Z

You can preview 1cb3b2f at https://pr20697-1cb3b2f.ngbuilds.io/.

mary-poppins · 2017-12-01T22:06:31Z

You can preview 7159fef at https://pr20697-7159fef.ngbuilds.io/.

mary-poppins · 2017-12-02T22:58:33Z

You can preview 8f020a5 at https://pr20697-8f020a5.ngbuilds.io/.

mary-poppins · 2017-12-02T23:36:32Z

You can preview b831b5a at https://pr20697-b831b5a.ngbuilds.io/.

mary-poppins · 2017-12-03T02:25:59Z

You can preview 822245d at https://pr20697-822245d.ngbuilds.io/.

mary-poppins · 2017-12-03T03:15:20Z

You can preview 2552d12 at https://pr20697-2552d12.ngbuilds.io/.

mary-poppins · 2017-12-03T03:29:49Z

You can preview 28edf58 at https://pr20697-28edf58.ngbuilds.io/.

mary-poppins · 2017-12-03T09:34:33Z

You can preview 7c3d378 at https://pr20697-7c3d378.ngbuilds.io/.

mary-poppins · 2017-12-03T13:24:40Z

You can preview 500f414 at https://pr20697-500f414.ngbuilds.io/.

mary-poppins · 2017-12-03T14:19:42Z

You can preview f3409ab at https://pr20697-f3409ab.ngbuilds.io/.

mary-poppins · 2017-12-03T14:43:41Z

You can preview eb07c9d at https://pr20697-eb07c9d.ngbuilds.io/.

mary-poppins · 2017-12-04T00:03:28Z

You can preview 7fa6a01 at https://pr20697-7fa6a01.ngbuilds.io/.

petebacondarwin · 2018-02-06T14:21:01Z

Rebased and force pushed to see if I clear the Travis errors

mary-poppins · 2018-02-06T14:32:10Z

You can preview 0c61a6c at https://pr20697-0c61a6c.ngbuilds.io/.

ngbot · 2018-02-08T17:24:05Z

Hi @wardbell! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

ngbot · 2018-02-08T17:24:09Z

Hi @wardbell! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

mary-poppins · 2018-02-13T06:42:54Z

You can preview 5f3dc46 at https://pr20697-5f3dc46.ngbuilds.io/.

petebacondarwin

This review is only from the point of view of AIO infrastructure, not the docs or examples themselves.

petebacondarwin · 2018-02-13T06:41:55Z

aio/tools/examples/shared/package.json

@@ -36,7 +36,7 @@
    "angular-in-memory-web-api": "~0.5.0",
    "core-js": "^2.4.1",
    "express": "^4.14.1",
-    "rxjs": "^5.5.0",
+    "rxjs": "^5.5.6",


I believe that you need to fix up the yarn.lock file associated with this package.json.

It would be nice too if I could remember why I bumped it. After reviewing RxJS changelog no reason leaps out at me. I'll roll back and confirm.
Update: there was no point to this change and I reverted it.

petebacondarwin · 2018-02-13T06:42:30Z

aio/src/app/embedded/code/code-example.component.ts

@@ -48,7 +48,8 @@ export class CodeExampleComponent implements OnInit {
    // Now remove the title attribute to prevent unwanted tooltip popups when hovering over the code.
    element.removeAttribute('title');

-    this.isAvoid = this.path.indexOf('.avoid.') !== -1;
+    const avoid = getBoolFromAttribute(element, 'avoid');
+    this.isAvoid = avoid || this.path.indexOf('.avoid.') !== -1;


No unit tests for this feature.

Fair enough. Will add.

Tests have been added.

…gular#20165) - Update tooling to support revised testing guide (PR angular#20697). - Require jasmine upgrade for examples that use marble testing. - Copy `cli/package.json` to `testing/` and add `jasmine-marbles`. - Resolve merge conflicts created by `NgModules` guides. PR Close angular#20165

- updates tests - heavy prose revisions - uses HttpClient (with angular-in-memory-web-api) - test HeroService using `HttpClientTestingModule` - scrub away most By.CSS - fake async observable with `asyncData()` - extensive Twain work - different take on retryWhen - remove app barrels (& systemjs.extras) which troubled plunker/systemjs - add dummy export const to hero.ts (plunkr/systemjs fails w/o it) - shrink and re-organize TOC - add marble testing package and tests - demonstrate the "no beforeEach()" test coding style - add section on Http service testing - prepare for stackblitz - confirm works in plunker except excluded marble test - add tests for avoidFile class feature of CodeExampleComponent

wardbell · 2018-02-23T20:42:12Z

@petebacondarwin This works for master and should work for patch. Do you feel comfortable setting those labels? I'm not personally up-to-speed on that.

mary-poppins · 2018-02-23T20:47:07Z

You can preview a324d1f at https://pr20697-a324d1f.ngbuilds.io/.

petebacondarwin · 2018-02-24T10:08:34Z

I don't see any reason why this should not land on stable as well as master.

- updates tests - heavy prose revisions - uses HttpClient (with angular-in-memory-web-api) - test HeroService using `HttpClientTestingModule` - scrub away most By.CSS - fake async observable with `asyncData()` - extensive Twain work - different take on retryWhen - remove app barrels (& systemjs.extras) which troubled plunker/systemjs - add dummy export const to hero.ts (plunkr/systemjs fails w/o it) - shrink and re-organize TOC - add marble testing package and tests - demonstrate the "no beforeEach()" test coding style - add section on Http service testing - prepare for stackblitz - confirm works in plunker except excluded marble test - add tests for avoidFile class feature of CodeExampleComponent PR Close #20697

- updates tests - heavy prose revisions - uses HttpClient (with angular-in-memory-web-api) - test HeroService using `HttpClientTestingModule` - scrub away most By.CSS - fake async observable with `asyncData()` - extensive Twain work - different take on retryWhen - remove app barrels (& systemjs.extras) which troubled plunker/systemjs - add dummy export const to hero.ts (plunkr/systemjs fails w/o it) - shrink and re-organize TOC - add marble testing package and tests - demonstrate the "no beforeEach()" test coding style - add section on Http service testing - prepare for stackblitz - confirm works in plunker except excluded marble test - add tests for avoidFile class feature of CodeExampleComponent PR Close angular#20697

…gular#20165) - Update tooling to support revised testing guide (PR angular#20697). - Require jasmine upgrade for examples that use marble testing. - Copy `cli/package.json` to `testing/` and add `jasmine-marbles`. - Resolve merge conflicts created by `NgModules` guides. PR Close angular#20165

- updates tests - heavy prose revisions - uses HttpClient (with angular-in-memory-web-api) - test HeroService using `HttpClientTestingModule` - scrub away most By.CSS - fake async observable with `asyncData()` - extensive Twain work - different take on retryWhen - remove app barrels (& systemjs.extras) which troubled plunker/systemjs - add dummy export const to hero.ts (plunkr/systemjs fails w/o it) - shrink and re-organize TOC - add marble testing package and tests - demonstrate the "no beforeEach()" test coding style - add section on Http service testing - prepare for stackblitz - confirm works in plunker except excluded marble test - add tests for avoidFile class feature of CodeExampleComponent PR Close angular#20697

angular-automatic-lock-bot · 2019-09-13T09:50:50Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

wardbell added comp: docs state: WIP labels Nov 29, 2017

wardbell self-assigned this Nov 29, 2017

googlebot added the cla: yes label Nov 29, 2017

Foxandxss mentioned this pull request Nov 29, 2017

List of updates needed for CLI docs #19510

Closed

24 tasks

gkalpak mentioned this pull request Nov 29, 2017

build(aio): migrate plunker to stackblitz #20165

Closed

wardbell force-pushed the clify-testing branch from a14e2b6 to 1cb3b2f Compare December 1, 2017 01:27

wardbell force-pushed the clify-testing branch from 1cb3b2f to 7159fef Compare December 1, 2017 21:54

wardbell force-pushed the clify-testing branch 2 times, most recently from 613349e to 8f020a5 Compare December 2, 2017 22:45

wardbell force-pushed the clify-testing branch from 8f020a5 to b831b5a Compare December 2, 2017 23:24

wardbell force-pushed the clify-testing branch from b831b5a to 822245d Compare December 3, 2017 02:15

wardbell force-pushed the clify-testing branch from 822245d to 2552d12 Compare December 3, 2017 03:06

wardbell force-pushed the clify-testing branch from 2552d12 to 28edf58 Compare December 3, 2017 03:20

wardbell force-pushed the clify-testing branch from 28edf58 to 7c3d378 Compare December 3, 2017 09:23

wardbell force-pushed the clify-testing branch from 500f414 to f3409ab Compare December 3, 2017 14:07

wardbell force-pushed the clify-testing branch from f3409ab to eb07c9d Compare December 3, 2017 14:33

petebacondarwin force-pushed the clify-testing branch from f01581a to 0c61a6c Compare February 6, 2018 14:20

gkalpak mentioned this pull request Feb 6, 2018

1st-specs.testing.zip not working in Windows 10 environment #18288

Closed

petebacondarwin force-pushed the clify-testing branch from 0c61a6c to 5f3dc46 Compare February 13, 2018 06:35

petebacondarwin requested changes Feb 13, 2018

View reviewed changes

kapunahelewong mentioned this pull request Feb 23, 2018

docs(aio): Testing: Description and code don't match #16064

Closed

wardbell force-pushed the clify-testing branch from 5f3dc46 to a324d1f Compare February 23, 2018 20:38

petebacondarwin approved these changes Feb 24, 2018

View reviewed changes

petebacondarwin added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Feb 24, 2018

petebacondarwin removed request for vikerman and StephenFluin February 24, 2018 10:09

alexeagle closed this in a7e1f23 Feb 26, 2018

wardbell deleted the clify-testing branch March 6, 2018 03:01

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: testing guide for CLI #20697

docs: testing guide for CLI #20697

wardbell commented Nov 29, 2017 •

edited

Loading

mary-poppins commented Nov 29, 2017

mary-poppins commented Dec 1, 2017

mary-poppins commented Dec 1, 2017

mary-poppins commented Dec 2, 2017

mary-poppins commented Dec 2, 2017

mary-poppins commented Dec 3, 2017

mary-poppins commented Dec 3, 2017

mary-poppins commented Dec 3, 2017

mary-poppins commented Dec 3, 2017

mary-poppins commented Dec 3, 2017

mary-poppins commented Dec 3, 2017

mary-poppins commented Dec 3, 2017

mary-poppins commented Dec 4, 2017

petebacondarwin commented Feb 6, 2018

mary-poppins commented Feb 6, 2018

ngbot bot commented Feb 8, 2018

ngbot bot commented Feb 8, 2018

mary-poppins commented Feb 13, 2018

petebacondarwin left a comment

petebacondarwin Feb 13, 2018

wardbell Feb 23, 2018 •

edited

Loading

petebacondarwin Feb 13, 2018

wardbell Feb 23, 2018

wardbell Feb 23, 2018

wardbell commented Feb 23, 2018

mary-poppins commented Feb 23, 2018

petebacondarwin commented Feb 24, 2018

angular-automatic-lock-bot bot commented Sep 13, 2019

docs: testing guide for CLI #20697

docs: testing guide for CLI #20697

Conversation

wardbell commented Nov 29, 2017 • edited Loading

PR Checklist

PR Type

mary-poppins commented Nov 29, 2017

mary-poppins commented Dec 1, 2017

mary-poppins commented Dec 1, 2017

mary-poppins commented Dec 2, 2017

mary-poppins commented Dec 2, 2017

mary-poppins commented Dec 3, 2017

mary-poppins commented Dec 3, 2017

mary-poppins commented Dec 3, 2017

mary-poppins commented Dec 3, 2017

mary-poppins commented Dec 3, 2017

mary-poppins commented Dec 3, 2017

mary-poppins commented Dec 3, 2017

mary-poppins commented Dec 4, 2017

petebacondarwin commented Feb 6, 2018

mary-poppins commented Feb 6, 2018

ngbot bot commented Feb 8, 2018

ngbot bot commented Feb 8, 2018

mary-poppins commented Feb 13, 2018

petebacondarwin left a comment

Choose a reason for hiding this comment

petebacondarwin Feb 13, 2018

Choose a reason for hiding this comment

wardbell Feb 23, 2018 • edited Loading

Choose a reason for hiding this comment

petebacondarwin Feb 13, 2018

Choose a reason for hiding this comment

wardbell Feb 23, 2018

Choose a reason for hiding this comment

wardbell Feb 23, 2018

Choose a reason for hiding this comment

wardbell commented Feb 23, 2018

mary-poppins commented Feb 23, 2018

petebacondarwin commented Feb 24, 2018

angular-automatic-lock-bot bot commented Sep 13, 2019

wardbell commented Nov 29, 2017 •

edited

Loading

wardbell Feb 23, 2018 •

edited

Loading