fix(upgrade): downgraded component not always attached to the app #22869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a case like ng1 > ng2-downgraded > ng1-upgraded > ng2-downgraded, the last component would not be attached to the application and would not be part of change detection Closes angular#22581
14 tasks
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Nov 21, 2018
…ngradeModule()` Previously, nested downgraded components would not be created/destroyed inside the Angular zone (as they should) and they should not be wired up correctly for change detection. This commit ensures that ngUpgrade correctly detects whether this is an ngUpgradeLite app (i.e. one using `downgradeModule()` instead of `UpgradeModule`) and appropriately handles components, even if they are nested inside other downgraded components. Fixes angular#22581 Closes angular#22869 Closes angular#27083
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Nov 22, 2018
…ngradeModule()` Previously, nested downgraded components would not be created/destroyed inside the Angular zone (as they should) and they should not be wired up correctly for change detection. This commit ensures that ngUpgrade correctly detects whether this is an ngUpgradeLite app (i.e. one using `downgradeModule()` instead of `UpgradeModule`) and appropriately handles components, even if they are nested inside other downgraded components. Fixes angular#22581 Closes angular#22869 Closes angular#27083
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Nov 23, 2018
…ngradeModule()` Previously, nested downgraded components would not be created/destroyed inside the Angular zone (as they should) and they would not be wired up correctly for change detection. This commit ensures that ngUpgrade correctly detects whether this is an ngUpgradeLite app (i.e. one using `downgradeModule()` instead of `UpgradeModule`) and appropriately handles components, even if they are nested inside other downgraded components. Fixes angular#22581 Closes angular#22869 Closes angular#27083
6 tasks
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Dec 5, 2018
…ngradeModule()` Previously, nested downgraded components would not be created/destroyed inside the Angular zone (as they should) and they would not be wired up correctly for change detection. This commit ensures that ngUpgrade correctly detects whether this is an ngUpgradeLite app (i.e. one using `downgradeModule()` instead of `UpgradeModule`) and appropriately handles components, even if they are nested inside other downgraded components. Fixes angular#22581 Closes angular#22869 Closes angular#27083
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Dec 10, 2018
…ngradeModule()` Previously, nested downgraded components would not be created/destroyed inside the Angular zone (as they should) and they would not be wired up correctly for change detection. This commit ensures that ngUpgrade correctly detects whether this is an ngUpgradeLite app (i.e. one using `downgradeModule()` instead of `UpgradeModule`) and appropriately handles components, even if they are nested inside other downgraded components. Fixes angular#22581 Closes angular#22869 Closes angular#27083
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Dec 12, 2018
…ngradeModule()` Previously, nested downgraded components would not be created/destroyed inside the Angular zone (as they should) and they would not be wired up correctly for change detection. This commit ensures that ngUpgrade correctly detects whether this is an ngUpgradeLite app (i.e. one using `downgradeModule()` instead of `UpgradeModule`) and appropriately handles components, even if they are nested inside other downgraded components. Fixes angular#22581 Closes angular#22869 Closes angular#27083
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Dec 13, 2018
…ngradeModule()` Previously, nested downgraded components would not be created/destroyed inside the Angular zone (as they should) and they would not be wired up correctly for change detection. This commit ensures that ngUpgrade correctly detects whether this is an ngUpgradeLite app (i.e. one using `downgradeModule()` instead of `UpgradeModule`) and appropriately handles components, even if they are nested inside other downgraded components. Fixes angular#22581 Closes angular#22869 Closes angular#27083
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Dec 13, 2018
…ngradeModule()` Previously, nested downgraded components would not be created/destroyed inside the Angular zone (as they should) and they would not be wired up correctly for change detection. This commit ensures that ngUpgrade correctly detects whether this is an ngUpgradeLite app (i.e. one using `downgradeModule()` instead of `UpgradeModule`) and appropriately handles components, even if they are nested inside other downgraded components. Fixes angular#22581 Closes angular#22869 Closes angular#27083
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Dec 14, 2018
…ngradeModule()` Previously, nested downgraded components would not be created/destroyed inside the Angular zone (as they should) and they would not be wired up correctly for change detection. This commit ensures that ngUpgrade correctly detects whether this is an ngUpgradeLite app (i.e. one using `downgradeModule()` instead of `UpgradeModule`) and appropriately handles components, even if they are nested inside other downgraded components. Fixes angular#22581 Closes angular#22869 Closes angular#27083
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Dec 19, 2018
…ngradeModule()` Previously, nested downgraded components would not be created/destroyed inside the Angular zone (as they should) and they would not be wired up correctly for change detection. This commit ensures that ngUpgrade correctly detects whether this is an ngUpgradeLite app (i.e. one using `downgradeModule()` instead of `UpgradeModule`) and appropriately handles components, even if they are nested inside other downgraded components. Fixes angular#22581 Closes angular#22869 Closes angular#27083
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Dec 20, 2018
…ngradeModule()` Previously, nested downgraded components would not be created/destroyed inside the Angular zone (as they should) and they would not be wired up correctly for change detection. This commit ensures that ngUpgrade correctly detects whether this is an ngUpgradeLite app (i.e. one using `downgradeModule()` instead of `UpgradeModule`) and appropriately handles components, even if they are nested inside other downgraded components. Fixes angular#22581 Closes angular#22869 Closes angular#27083
matsko
pushed a commit
that referenced
this pull request
Dec 20, 2018
…ngradeModule()` (#27217) Previously, nested downgraded components would not be created/destroyed inside the Angular zone (as they should) and they would not be wired up correctly for change detection. This commit ensures that ngUpgrade correctly detects whether this is an ngUpgradeLite app (i.e. one using `downgradeModule()` instead of `UpgradeModule`) and appropriately handles components, even if they are nested inside other downgraded components. Fixes #22581 Closes #22869 Closes #27083 PR Close #27217
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
…ngradeModule()` (angular#27217) Previously, nested downgraded components would not be created/destroyed inside the Angular zone (as they should) and they would not be wired up correctly for change detection. This commit ensures that ngUpgrade correctly detects whether this is an ngUpgradeLite app (i.e. one using `downgradeModule()` instead of `UpgradeModule`) and appropriately handles components, even if they are nested inside other downgraded components. Fixes angular#22581 Closes angular#22869 Closes angular#27083 PR Close angular#27217
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
In a case like
ng1>ng2-downgraded>ng1-upgraded>ng2-downgraded, the lastng2-downgradedcomponent would not be attached to the application and therefore would not be part of change detectionIssue Number: #22581
What is the new behavior?
The last
ng2-downgradedcomponent will function as it shouldDoes this PR introduce a breaking change?
Other information