Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upgrade): downgraded component not always attached to the app #22869

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@FDIM
Copy link
Contributor

FDIM commented Mar 19, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

In a case like ng1 > ng2-downgraded > ng1-upgraded > ng2-downgraded, the last ng2-downgraded component would not be attached to the application and therefore would not be part of change detection

Issue Number: #22581

What is the new behavior?

The last ng2-downgraded component will function as it should

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

fix(upgrade): downgraded component not always attached to app
In a case like ng1 > ng2-downgraded > ng1-upgraded > ng2-downgraded, the last component would not be attached to the application and would not be part of change detection

Closes #22581

@googlebot googlebot added the cla: yes label Mar 19, 2018

gkalpak added a commit to gkalpak/angular that referenced this pull request Nov 21, 2018

fix(upgrade): correctly handle nested downgraded components with `dow…
…ngradeModule()`

Previously, nested downgraded components would not be created/destroyed
inside the Angular zone (as they should) and they should not be wired up
correctly for change detection.

This commit ensures that ngUpgrade correctly detects whether this is an
ngUpgradeLite app (i.e. one using `downgradeModule()` instead of
`UpgradeModule`) and appropriately handles components, even if they are
nested inside other downgraded components.

Fixes angular#22581
Closes angular#22869
Closes angular#27083

gkalpak added a commit to gkalpak/angular that referenced this pull request Nov 22, 2018

fix(upgrade): correctly handle nested downgraded components with `dow…
…ngradeModule()`

Previously, nested downgraded components would not be created/destroyed
inside the Angular zone (as they should) and they should not be wired up
correctly for change detection.

This commit ensures that ngUpgrade correctly detects whether this is an
ngUpgradeLite app (i.e. one using `downgradeModule()` instead of
`UpgradeModule`) and appropriately handles components, even if they are
nested inside other downgraded components.

Fixes angular#22581
Closes angular#22869
Closes angular#27083

gkalpak added a commit to gkalpak/angular that referenced this pull request Nov 23, 2018

fix(upgrade): correctly handle nested downgraded components with `dow…
…ngradeModule()`

Previously, nested downgraded components would not be created/destroyed
inside the Angular zone (as they should) and they would not be wired up
correctly for change detection.

This commit ensures that ngUpgrade correctly detects whether this is an
ngUpgradeLite app (i.e. one using `downgradeModule()` instead of
`UpgradeModule`) and appropriately handles components, even if they are
nested inside other downgraded components.

Fixes angular#22581
Closes angular#22869
Closes angular#27083

@gkalpak gkalpak referenced this pull request Nov 27, 2018

Closed

fix(upgrade): several ngUpgradeLite fixes #27217

4 of 6 tasks complete

gkalpak added a commit to gkalpak/angular that referenced this pull request Dec 5, 2018

fix(upgrade): correctly handle nested downgraded components with `dow…
…ngradeModule()`

Previously, nested downgraded components would not be created/destroyed
inside the Angular zone (as they should) and they would not be wired up
correctly for change detection.

This commit ensures that ngUpgrade correctly detects whether this is an
ngUpgradeLite app (i.e. one using `downgradeModule()` instead of
`UpgradeModule`) and appropriately handles components, even if they are
nested inside other downgraded components.

Fixes angular#22581
Closes angular#22869
Closes angular#27083

gkalpak added a commit to gkalpak/angular that referenced this pull request Dec 10, 2018

fix(upgrade): correctly handle nested downgraded components with `dow…
…ngradeModule()`

Previously, nested downgraded components would not be created/destroyed
inside the Angular zone (as they should) and they would not be wired up
correctly for change detection.

This commit ensures that ngUpgrade correctly detects whether this is an
ngUpgradeLite app (i.e. one using `downgradeModule()` instead of
`UpgradeModule`) and appropriately handles components, even if they are
nested inside other downgraded components.

Fixes angular#22581
Closes angular#22869
Closes angular#27083

gkalpak added a commit to gkalpak/angular that referenced this pull request Dec 12, 2018

fix(upgrade): correctly handle nested downgraded components with `dow…
…ngradeModule()`

Previously, nested downgraded components would not be created/destroyed
inside the Angular zone (as they should) and they would not be wired up
correctly for change detection.

This commit ensures that ngUpgrade correctly detects whether this is an
ngUpgradeLite app (i.e. one using `downgradeModule()` instead of
`UpgradeModule`) and appropriately handles components, even if they are
nested inside other downgraded components.

Fixes angular#22581
Closes angular#22869
Closes angular#27083

gkalpak added a commit to gkalpak/angular that referenced this pull request Dec 13, 2018

fix(upgrade): correctly handle nested downgraded components with `dow…
…ngradeModule()`

Previously, nested downgraded components would not be created/destroyed
inside the Angular zone (as they should) and they would not be wired up
correctly for change detection.

This commit ensures that ngUpgrade correctly detects whether this is an
ngUpgradeLite app (i.e. one using `downgradeModule()` instead of
`UpgradeModule`) and appropriately handles components, even if they are
nested inside other downgraded components.

Fixes angular#22581
Closes angular#22869
Closes angular#27083

gkalpak added a commit to gkalpak/angular that referenced this pull request Dec 13, 2018

fix(upgrade): correctly handle nested downgraded components with `dow…
…ngradeModule()`

Previously, nested downgraded components would not be created/destroyed
inside the Angular zone (as they should) and they would not be wired up
correctly for change detection.

This commit ensures that ngUpgrade correctly detects whether this is an
ngUpgradeLite app (i.e. one using `downgradeModule()` instead of
`UpgradeModule`) and appropriately handles components, even if they are
nested inside other downgraded components.

Fixes angular#22581
Closes angular#22869
Closes angular#27083

gkalpak added a commit to gkalpak/angular that referenced this pull request Dec 14, 2018

fix(upgrade): correctly handle nested downgraded components with `dow…
…ngradeModule()`

Previously, nested downgraded components would not be created/destroyed
inside the Angular zone (as they should) and they would not be wired up
correctly for change detection.

This commit ensures that ngUpgrade correctly detects whether this is an
ngUpgradeLite app (i.e. one using `downgradeModule()` instead of
`UpgradeModule`) and appropriately handles components, even if they are
nested inside other downgraded components.

Fixes angular#22581
Closes angular#22869
Closes angular#27083

gkalpak added a commit to gkalpak/angular that referenced this pull request Dec 19, 2018

fix(upgrade): correctly handle nested downgraded components with `dow…
…ngradeModule()`

Previously, nested downgraded components would not be created/destroyed
inside the Angular zone (as they should) and they would not be wired up
correctly for change detection.

This commit ensures that ngUpgrade correctly detects whether this is an
ngUpgradeLite app (i.e. one using `downgradeModule()` instead of
`UpgradeModule`) and appropriately handles components, even if they are
nested inside other downgraded components.

Fixes angular#22581
Closes angular#22869
Closes angular#27083

gkalpak added a commit to gkalpak/angular that referenced this pull request Dec 20, 2018

fix(upgrade): correctly handle nested downgraded components with `dow…
…ngradeModule()`

Previously, nested downgraded components would not be created/destroyed
inside the Angular zone (as they should) and they would not be wired up
correctly for change detection.

This commit ensures that ngUpgrade correctly detects whether this is an
ngUpgradeLite app (i.e. one using `downgradeModule()` instead of
`UpgradeModule`) and appropriately handles components, even if they are
nested inside other downgraded components.

Fixes angular#22581
Closes angular#22869
Closes angular#27083

matsko added a commit that referenced this pull request Dec 20, 2018

fix(upgrade): correctly handle nested downgraded components with `dow…
…ngradeModule()` (#27217)

Previously, nested downgraded components would not be created/destroyed
inside the Angular zone (as they should) and they would not be wired up
correctly for change detection.

This commit ensures that ngUpgrade correctly detects whether this is an
ngUpgradeLite app (i.e. one using `downgradeModule()` instead of
`UpgradeModule`) and appropriately handles components, even if they are
nested inside other downgraded components.

Fixes #22581
Closes #22869
Closes #27083

PR Close #27217

@matsko matsko closed this in 326b464 Dec 20, 2018

ngfelixl added a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

fix(upgrade): correctly handle nested downgraded components with `dow…
…ngradeModule()` (angular#27217)

Previously, nested downgraded components would not be created/destroyed
inside the Angular zone (as they should) and they would not be wired up
correctly for change detection.

This commit ensures that ngUpgrade correctly detects whether this is an
ngUpgradeLite app (i.e. one using `downgradeModule()` instead of
`UpgradeModule`) and appropriately handles components, even if they are
nested inside other downgraded components.

Fixes angular#22581
Closes angular#22869
Closes angular#27083

PR Close angular#27217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.