feat(ivy): a generic visitor which allows prefixing nodes for ngtsc #24230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview 1eecee3 at https://pr24230-1eecee3.ngbuilds.io/. |
|
You can preview 5a09601 at https://pr24230-5a09601.ngbuilds.io/. |
|
You can preview 5f526e9 at https://pr24230-5f526e9.ngbuilds.io/. |
This adds ngtsc/util/src/visitor, a utility for visiting TS ASTs that can add synthetic nodes immediately prior to certain types of nodes (e.g. class declarations). It's useful to lift definitions that need to be referenced repeatedly in generated code outside of the class that defines them.
|
You can preview 89314da at https://pr24230-89314da.ngbuilds.io/. |
alxhub
added
action: merge
vicb
reviewed
Jun 7, 2018
| const host = new InMemoryHost(); | ||
| files.forEach(file => host.writeFile(file.name, file.contents)); | ||
|
|
||
| const rootNames = files.map(file => host.getCanonicalFileName(file.name)); | ||
| const program = ts.createProgram(rootNames, {noLib: true, experimentalDecorators: true}, host); | ||
| const diags = [...program.getSyntacticDiagnostics(), ...program.getSemanticDiagnostics()]; | ||
| if (diags.length > 0) { | ||
| fail(diags.map(diag => diag.messageText).join(', ')); |
There was a problem hiding this comment.
is removing the fail() intended ?
There was a problem hiding this comment.
It was causing issues in g3.
vicb
approved these changes
Jun 7, 2018
mhevery
approved these changes
Jun 7, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds ngtsc/util/src/visitor, a utility for visiting TS ASTs that
can add synthetic nodes immediately prior to certain types of nodes (e.g.
class declarations). It's useful to lift definitions that need to be
referenced repeatedly in generated code outside of the class that defines
them.