Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: rewrite binding-syntax section in template-syntax.md #25561

Closed
wants to merge 1 commit into from

Conversation

kapunahelewong
Copy link
Contributor

@kapunahelewong kapunahelewong commented Aug 18, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Current section uses hero examples.

Issue Number:
Closes #18665

What is the new behavior?

Rewrite of Binding Section updates prose and introduces an example specific to Binding Syntax that demos the two examples that are currently explained in that section. It also moves away from heroes.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This is part 2 of the Template Syntax rewrite. The intention is that each part be rewritten with relevant, separate examples. When the entire Template Syntax document is complete, these will be broken out into their own standalone docs.

@kapunahelewong kapunahelewong added comp: docs target: patch This PR is targeted for the next patch release labels Aug 18, 2018
@kapunahelewong kapunahelewong changed the title docs: rewrite binding-syntax section in template-syntax.md [WIP]docs: rewrite binding-syntax section in template-syntax.md Aug 20, 2018
@kapunahelewong kapunahelewong changed the title [WIP]docs: rewrite binding-syntax section in template-syntax.md docs: rewrite binding-syntax section in template-syntax.md Aug 28, 2018
@mary-poppins
Copy link

You can preview 191194b at https://pr25561-191194b.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 521c71f at https://pr25561-521c71f.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 1bffd60 at https://pr25561-1bffd60.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 8648f10 at https://pr25561-8648f10.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 0bd3c2c at https://pr25561-0bd3c2c.ngbuilds.io/.

@kapunahelewong kapunahelewong force-pushed the binding-syntax branch 2 times, most recently from a9741ef to bce7244 Compare November 12, 2018 21:23
@mary-poppins
Copy link

You can preview bce7244 at https://pr25561-bce7244.ngbuilds.io/.

@mary-poppins
Copy link

You can preview c5213a9 at https://pr25561-c5213a9.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 0823229 at https://pr25561-0823229.ngbuilds.io/.

@mary-poppins
Copy link

You can preview d5235d7 at https://pr25561-d5235d7.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 2dc35b4 at https://pr25561-2dc35b4.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 6ee0bcc at https://pr25561-6ee0bcc.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 87e9601 at https://pr25561-87e9601.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 7f03ac1 at https://pr25561-7f03ac1.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 08e300b at https://pr25561-08e300b.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 699ed87 at https://pr25561-699ed87.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 95e56a1 at https://pr25561-95e56a1.ngbuilds.io/.

@mary-poppins
Copy link

You can preview eeb85ab at https://pr25561-eeb85ab.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 4188424 at https://pr25561-4188424.ngbuilds.io/.

@mary-poppins
Copy link

You can preview fcd7f94 at https://pr25561-fcd7f94.ngbuilds.io/.

@mary-poppins
Copy link

You can preview bad0ca6 at https://pr25561-bad0ca6.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 959e8b5 at https://pr25561-959e8b5.ngbuilds.io/.

@brandonroberts brandonroberts added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jun 13, 2019
@ngbot ngbot bot added the action: merge The PR is ready for merge by the caretaker label Jun 13, 2019
@mary-poppins
Copy link

You can preview 0f19f8d at https://pr25561-0f19f8d.ngbuilds.io/.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort2: days freq3: high merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note refactoring Issue that involves refactoring or code-cleanup risk: medium target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Template Syntax sections claim that no column span property exists.
5 participants