Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]docs: add documentation for ngNonBindable #28577

Closed
wants to merge 1 commit into from
Closed

[WIP]docs: add documentation for ngNonBindable #28577

wants to merge 1 commit into from

Conversation

kapunahelewong
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number:
Closes #19497

What is the new behavior?

A new short section in Attribute Binding explaining ngNonBindable and an addition to the Attribute Binding example to demo it.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kapunahelewong kapunahelewong requested a review from a team as a code owner February 6, 2019 21:26
@kapunahelewong kapunahelewong added comp: docs effort1: hours target: patch This PR is targeted for the next patch release labels Feb 6, 2019
@ngbot ngbot bot added this to the needsTriage milestone Feb 6, 2019
trotyl
trotyl reviewed Feb 7, 2019
View reviewed changes
aio/content/guide/attribute-directives.md Outdated

## `ngNonBindable`

The built-in attribute directive `ngNonBindable` allows you to render code in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ngNonBindable is not a directive, but a template primitive like ng-template and ng-content.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @trotyl. Would this be more accurate?

The built-in template primitive...

And do you think it works here in the attribute directives doc? EDIT: as in maybe it should go elsewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And maybe I should mention it looks like an attribute directive but isn't?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically I think it belongs to template syntax, but I also prefer to having their own API entries for all keyword-based primitives (ng-template, ng-container, ng-content, [ngNonBindable]).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trotyl

Hey @brandonroberts and @jenniferfell what are your thoughts on where this ought to go?

@kapunahelewong kapunahelewong mentioned this pull request Feb 7, 2019
Closed
@kapunahelewong kapunahelewong changed the title docs: add documentation for ngNonBindable [WIP]docs: add documentation for ngNonBindable Feb 11, 2019
@mary-poppins
Copy link

You can preview 9f94015 at https://pr28577-9f94015.ngbuilds.io/.
You can preview 7e959ca at https://pr28577-7e959ca.ngbuilds.io/.
You can preview b22e1d0 at https://pr28577-b22e1d0.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 68b823c at https://pr28577-68b823c.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 4c38646 at https://pr28577-4c38646.ngbuilds.io/.

@ngbot ngbot bot modified the milestones: needsTriage, Backlog May 21, 2019
@mary-poppins
Copy link

You can preview 301dbe8 at https://pr28577-301dbe8.ngbuilds.io/.

@mary-poppins
Copy link

You can preview bba6c3c at https://pr28577-bba6c3c.ngbuilds.io/.

@kapunahelewong
Copy link
Contributor Author

Holding this PR until Template Syntax PRs merge.

Binding Syntax: #25561
Property Binding: #25770
Attribute Binding: #26004
Two-way binding: #26278
Built-in directives: #27273
Template Ref Vars: #27371
Inputs Outputs: #27685
Template Expression Operators: #28087

After these are merged, Template Syntax will be separated into different docs. At that point, we can find the best place for this.

@ajitsinghkaler
Copy link
Contributor

@kapunahelewong all these pr has been merged so we can start merging this pr if you need any help please tell me. Or if I can work on this pr.

@kapunahelewong
Copy link
Contributor Author

kapunahelewong commented Mar 10, 2020 •
edited

Thank you, @ajitsinghkaler! If you'd like, you could take this PR over. It will still need to be reviewed by engineering and docs to make sure it's in accordance with what should be in the documentation about it as well as that it is technically correct. If you take it, please tag me and reference the PR and I will close this one out and refer to your PR. 🌈

EDIT: I won't be able to work on it for some time as I have other projects before it.

@ajitsinghkaler
Copy link
Contributor

Would love to please assign it to me

ajitsinghkaler added a commit to ajitsinghkaler/angular that referenced this pull request Apr 10, 2020
@ajitsinghkaler
docs: add documentation for ngNonBindable
6132b9d 
Ng non bindable documentatioon was not presennt added documentation for ng non bindable

Fixes angular#28577
ajitsinghkaler added a commit to ajitsinghkaler/angular that referenced this pull request Apr 10, 2020
@ajitsinghkaler
docs: add documentation for ngNonBindable
7945460 
Ng non bindable documentatioon was not presennt added documentation for ng non bindable

Fixes angular#28577 angular#19497
ajitsinghkaler added a commit to ajitsinghkaler/angular that referenced this pull request Apr 10, 2020
@ajitsinghkaler
docs: add documentation for ngNonBindable
207dbb3 
ngNonBindable documentation was not present added documentation for ngNonBindable

Fixes angular#28577 angular#19497
@ajitsinghkaler ajitsinghkaler mentioned this pull request Apr 10, 2020
Closed
14 tasks
@ajitsinghkaler
Copy link
Contributor

@kapunahelewong you can close this in favor of #36560

@kapunahelewong
Copy link
Contributor Author

Very kind of you! Thanks a bunch, @ajitsinghkaler!

@ajitsinghkaler
Copy link
Contributor

No problem

ajitsinghkaler added a commit to ajitsinghkaler/angular that referenced this pull request Apr 15, 2020
@ajitsinghkaler
docs: add documentation for ngNonBindable
5a3e493 
ngNonBindable documentation was not present added documentation for ngNonBindable

Fixes angular#28577 angular#19497
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 11, 2020
ajitsinghkaler added a commit to ajitsinghkaler/angular that referenced this pull request May 18, 2020
@ajitsinghkaler
docs: add documentation for ngNonBindable
749bf5f 
ngNonBindable documentation was not present added documentation for ngNonBindable

Fixes angular#28577 angular#19497
ajitsinghkaler added a commit to ajitsinghkaler/angular that referenced this pull request Jun 14, 2020
@ajitsinghkaler
docs: add documentation for ngNonBindable
c8c13c0 
ngNonBindable documentation was not present, on docs site added documentation for ngNonBindable. With this template primitive, Angular won't
evaluate expressions in elements.

Fixes angular#28577 Fixes#19497
ajitsinghkaler added a commit to ajitsinghkaler/angular that referenced this pull request Jun 14, 2020
@ajitsinghkaler
docs: add documentation for ngNonBindable
589859d 
ngNonBindable documentation was not present, on docs site added documentation for ngNonBindable. With this template primitive, Angular won't
evaluate expressions in elements.

Fixes angular#28577 Fixes angular#19497
atscott pushed a commit that referenced this pull request Nov 17, 2020
@ajitsinghkaler @atscott
docs: add documentation for ngNonBindable (#36560)
a88bc64 
ngNonBindable documentation was not present, on docs site added documentation for ngNonBindable. With this template primitive, Angular won't
evaluate expressions in elements.

Fixes #28577 Fixes #19497

PR Close #36560
atscott pushed a commit that referenced this pull request Nov 17, 2020
@ajitsinghkaler @atscott
docs: add documentation for ngNonBindable (#36560)
806d7aa 
ngNonBindable documentation was not present, on docs site added documentation for ngNonBindable. With this template primitive, Angular won't
evaluate expressions in elements.

Fixes #28577 Fixes #19497

PR Close #36560
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoostK JoostK JoostK left review comments

@trotyl trotyl trotyl left review comments

@brandonroberts brandonroberts Awaiting requested review from brandonroberts

@jenniferfell jenniferfell Awaiting requested review from jenniferfell

Assignees

@ajitsinghkaler ajitsinghkaler

Labels
cla: yes effort1: hours freq1: low risk: low target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

ngNonBindable and ngNoForm are not in the docs
6 participants
@kapunahelewong @mary-poppins @ajitsinghkaler @JoostK @trotyl @googlebot