ci(docs-infra): run tests against local Angular packages too #26202

gkalpak · 2018-10-01T21:41:47Z

This allows catching regressions earlier.

mary-poppins · 2018-10-01T22:32:57Z

You can preview 1dd3f31 at https://pr26202-1dd3f31.ngbuilds.io/.

mary-poppins · 2018-10-01T22:36:15Z

You can preview 4353aa7 at https://pr26202-4353aa7.ngbuilds.io/.

mary-poppins · 2018-10-02T08:46:45Z

You can preview a6e89a1 at https://pr26202-a6e89a1.ngbuilds.io/.

mary-poppins · 2018-10-02T09:50:56Z

You can preview db28ec1 at https://pr26202-db28ec1.ngbuilds.io/.

mary-poppins · 2018-10-02T10:17:04Z

You can preview 0a79555 at https://pr26202-0a79555.ngbuilds.io/.

mary-poppins · 2018-10-02T11:04:54Z

You can preview e3a9c05 at https://pr26202-e3a9c05.ngbuilds.io/.

petebacondarwin · 2018-10-04T15:23:26Z

aio/src/app/custom-elements/contributor/contributor.service.spec.ts

@@ -44,7 +44,7 @@ describe('ContributorService', () => {
    it('contributors observable should complete', () => {
      let completed = false;
      contribService.contributors.subscribe(undefined, undefined, () => completed = true);
-      expect(true).toBe(true, 'observable completed');
+      expect(completed).toBe(true, 'observable completed');


petebacondarwin · 2018-10-04T15:28:19Z

scripts/ci/install.sh

  ${CI_MODE} == "aio_e2e" ||
  ${CI_MODE} == "aio_tools_test"
 ]]; then
  # angular.io: Install all yarn dependencies according to angular.io/yarn.lock
  travisFoldStart "yarn-install.aio"
    (
-      # HACK (don't submit with this): Build Angular
-      ./build.sh --packages=compiler,core,elements --examples=false
-


petebacondarwin · 2018-10-04T15:32:42Z

aio/src/app/shared/copier.service.ts

@@ -34,7 +35,7 @@ export class CopierService {
      this.fakeElem.style[ isRTL ? 'right' : 'left' ] = '-9999px';

      // Move element to the same position vertically
-      const yPosition = window.pageYOffset || document.documentElement.scrollTop;
+      const yPosition = window.pageYOffset || docElem.scrollTop;


I get the feeling that this change should be in a different commit ... 🤔

👍 Agreed 😁
For the record, this was failing because of the updated lib.dom.d.ts typings in latest TS (which is brought in with aio-use-local).

I moved it to a new commit, then it felt appropriate to upgrade TS to 3.1.x (which this change is related to), which in turn required upgrading Angular to 7.0.0-rc.0 😁

Now you have to review again 😛

petebacondarwin

LGTM - but I wonder if we should be adding new jobs to CircleCI rather than Travis?
Or are we just not in a position to build AIO via CircleCI yet?

mary-poppins · 2018-10-05T09:47:13Z

You can preview c18a77c at https://pr26202-c18a77c.ngbuilds.io/.

jasonaden · 2018-10-08T19:04:32Z

@gkalpak Can you create a separate PR for patch? Specifically because of the changes to package.json and yarn.lock as these will never merge cleanly.

This was accidentally merged with 4d506ac and 87f60bc. The build script is called in `scripts/ci/build.sh` (if necessary).

This is necessary to avoid webpack/webpack#8082, when installing dependencies without taking the lockfile into account (e.g. with `yarn aio-use-local` - locally or on CI).

mary-poppins · 2018-10-08T19:59:35Z

You can preview 7b34786 at https://pr26202-7b34786.ngbuilds.io/.

gkalpak · 2018-10-08T20:13:51Z

Rebased this on master and changed PR target to master-only.
Created #26306 for patch.

PR Close #26202

This is necessary to avoid webpack/webpack#8082, when installing dependencies without taking the lockfile into account (e.g. with `yarn aio-use-local` - locally or on CI). PR Close #26202

…1.1 (#26202) PR Close #26202

This was accidentally merged with 4d506ac and 87f60bc. The build script is called in `scripts/ci/build.sh` (if necessary). PR Close angular#26202

PR Close angular#26202

…#26202) PR Close angular#26202

This is necessary to avoid webpack/webpack#8082, when installing dependencies without taking the lockfile into account (e.g. with `yarn aio-use-local` - locally or on CI). PR Close angular#26202

…1.1 (angular#26202) PR Close angular#26202

angular-automatic-lock-bot · 2019-09-14T03:21:13Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Oct 1, 2018

gkalpak added state: WIP area: build & ci Related the build and CI infrastructure of the project comp: docs-infra target: patch This PR is targeted for the next patch release labels Oct 1, 2018

gkalpak force-pushed the ci-aio-test-with-local-packages branch from 1dd3f31 to 4353aa7 Compare October 1, 2018 22:26

gkalpak force-pushed the ci-aio-test-with-local-packages branch from 4353aa7 to a6e89a1 Compare October 2, 2018 08:38

gkalpak added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Oct 2, 2018

gkalpak changed the title ~~WIP - ci(docs-infra): run tests against local Angular packages too~~ ci(docs-infra): run tests against local Angular packages too Oct 2, 2018

gkalpak force-pushed the ci-aio-test-with-local-packages branch from a6e89a1 to db28ec1 Compare October 2, 2018 09:42

gkalpak force-pushed the ci-aio-test-with-local-packages branch from db28ec1 to 0a79555 Compare October 2, 2018 10:09

gkalpak force-pushed the ci-aio-test-with-local-packages branch from 0a79555 to e3a9c05 Compare October 2, 2018 10:57

gkalpak requested review from IgorMinar and petebacondarwin October 3, 2018 20:44

gkalpak assigned IgorMinar Oct 3, 2018

petebacondarwin reviewed Oct 4, 2018

View reviewed changes

petebacondarwin approved these changes Oct 4, 2018

View reviewed changes

IgorMinar approved these changes Oct 5, 2018

View reviewed changes

IgorMinar added the action: merge The PR is ready for merge by the caretaker label Oct 5, 2018

petebacondarwin approved these changes Oct 5, 2018

View reviewed changes

petebacondarwin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 5, 2018

gkalpak added 5 commits October 8, 2018 22:47

ci(docs-infra): remove unnecessary command

949519d

This was accidentally merged with 4d506ac and 87f60bc. The build script is called in `scripts/ci/build.sh` (if necessary).

test(docs-infra): fix tests

6d06fb5

ci(docs-infra): run tests against local Angular packages too

f759b26

build(docs-infra): upgrade webpack-cli to 3.1.2

d075f6c

This is necessary to avoid webpack/webpack#8082, when installing dependencies without taking the lockfile into account (e.g. with `yarn aio-use-local` - locally or on CI).

build(docs-infra): upgrade Angular to 7.0.0-rc.0 and TypeScript to 3.1.1

7b34786

gkalpak force-pushed the ci-aio-test-with-local-packages branch from c18a77c to 7b34786 Compare October 8, 2018 19:55

gkalpak added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Oct 8, 2018

gkalpak mentioned this pull request Oct 8, 2018

ci(docs-infra): run tests against local Angular packages too #26306

Closed

jasonaden closed this in b46fa92 Oct 8, 2018

jasonaden pushed a commit that referenced this pull request Oct 8, 2018

test(docs-infra): fix tests (#26202)

10e414f

PR Close #26202

jasonaden pushed a commit that referenced this pull request Oct 8, 2018

ci(docs-infra): run tests against local Angular packages too (#26202)

1b1c8ee

PR Close #26202

jasonaden pushed a commit that referenced this pull request Oct 8, 2018

build(docs-infra): upgrade Angular to 7.0.0-rc.0 and TypeScript to 3.…

9320ec0

…1.1 (#26202) PR Close #26202

gkalpak deleted the ci-aio-test-with-local-packages branch October 8, 2018 20:53

FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019

test(docs-infra): fix tests (angular#26202)

3bb3053

PR Close angular#26202

FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019

ci(docs-infra): run tests against local Angular packages too (angular…

44a82c6

…#26202) PR Close angular#26202

FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019

build(docs-infra): upgrade Angular to 7.0.0-rc.0 and TypeScript to 3.…

798852b

…1.1 (angular#26202) PR Close angular#26202

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci(docs-infra): run tests against local Angular packages too #26202

ci(docs-infra): run tests against local Angular packages too #26202

gkalpak commented Oct 1, 2018

mary-poppins commented Oct 1, 2018

mary-poppins commented Oct 1, 2018

mary-poppins commented Oct 2, 2018

mary-poppins commented Oct 2, 2018

mary-poppins commented Oct 2, 2018

mary-poppins commented Oct 2, 2018

petebacondarwin Oct 4, 2018

petebacondarwin Oct 4, 2018

IgorMinar Oct 5, 2018

petebacondarwin Oct 4, 2018

gkalpak Oct 5, 2018

gkalpak Oct 5, 2018

petebacondarwin left a comment

mary-poppins commented Oct 5, 2018

jasonaden commented Oct 8, 2018

mary-poppins commented Oct 8, 2018

gkalpak commented Oct 8, 2018

angular-automatic-lock-bot bot commented Sep 14, 2019

ci(docs-infra): run tests against local Angular packages too #26202

ci(docs-infra): run tests against local Angular packages too #26202

Conversation

gkalpak commented Oct 1, 2018

mary-poppins commented Oct 1, 2018

mary-poppins commented Oct 1, 2018

mary-poppins commented Oct 2, 2018

mary-poppins commented Oct 2, 2018

mary-poppins commented Oct 2, 2018

mary-poppins commented Oct 2, 2018

petebacondarwin Oct 4, 2018

Choose a reason for hiding this comment

petebacondarwin Oct 4, 2018

Choose a reason for hiding this comment

IgorMinar Oct 5, 2018

Choose a reason for hiding this comment

petebacondarwin Oct 4, 2018

Choose a reason for hiding this comment

gkalpak Oct 5, 2018

Choose a reason for hiding this comment

gkalpak Oct 5, 2018

Choose a reason for hiding this comment

petebacondarwin left a comment

Choose a reason for hiding this comment

mary-poppins commented Oct 5, 2018

jasonaden commented Oct 8, 2018

mary-poppins commented Oct 8, 2018

gkalpak commented Oct 8, 2018

angular-automatic-lock-bot bot commented Sep 14, 2019