Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add example and edit two-way binding section of Template Syntax #26278

Closed

Conversation

kapunahelewong
Copy link
Contributor

@kapunahelewong kapunahelewong commented Oct 5, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Rewrite and addition of an example for the two-way binding section.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This is the 6th installment of the Template Syntax rewrite so that it can be broken into separate documents.

@kapunahelewong kapunahelewong added comp: docs aio: preview target: patch This PR is targeted for the next patch release labels Oct 9, 2018
@mary-poppins
Copy link

You can preview 8406eb0 at https://pr26278-8406eb0.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 26c3a38 at https://pr26278-26c3a38.ngbuilds.io/.

@mary-poppins
Copy link

You can preview db782e5 at https://pr26278-db782e5.ngbuilds.io/.

@mary-poppins
Copy link

You can preview f4f9fb8 at https://pr26278-f4f9fb8.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 33cfc04 at https://pr26278-33cfc04.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 3b7b991 at https://pr26278-3b7b991.ngbuilds.io/.

@ngbot ngbot bot added this to the needsTriage milestone Jan 24, 2019
@mary-poppins
Copy link

You can preview d5fbbc4 at https://pr26278-d5fbbc4.ngbuilds.io/.

@mary-poppins
Copy link

You can preview b1fb947 at https://pr26278-b1fb947.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 46b4fbb at https://pr26278-46b4fbb.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 4b42e2b at https://pr26278-4b42e2b.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 4f7cb95 at https://pr26278-4f7cb95.ngbuilds.io/.

@mary-poppins
Copy link

You can preview df3e6bd at https://pr26278-df3e6bd.ngbuilds.io/.

@mary-poppins
Copy link

You can preview c1a975d at https://pr26278-c1a975d.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 152df91 at https://pr26278-152df91.ngbuilds.io/.

@mary-poppins
Copy link

You can preview e4278ab at https://pr26278-e4278ab.ngbuilds.io/.

@brandonroberts brandonroberts added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jun 13, 2019
@ngbot ngbot bot added the action: merge The PR is ready for merge by the caretaker label Jun 13, 2019
@brandonroberts
Copy link
Contributor

Caretaker note: The Codefresh job is unrelated and still pending. I am using a global approval

@AndrewKushnir AndrewKushnir added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Jun 14, 2019
@AndrewKushnir
Copy link
Contributor

@kapunahelewong, it looks like this PR now has a conflict with master branch after merging PR 25561 that also updated .github/CODEOWNERS file. Could you please rebase this PR and resolve conflict(s)? Feel free to add "merge" label back once PR is updated. Thank you.

@mary-poppins
Copy link

You can preview 361795b at https://pr26278-361795b.ngbuilds.io/.

@kapunahelewong kapunahelewong added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jun 14, 2019
@kapunahelewong kapunahelewong deleted the two-way-binding branch June 20, 2019 18:18
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes effort2: days freq3: high merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note risk: medium target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants