-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: rewrite built-in directives section of Template Syntax #27273
Conversation
2454fba
to
2c8cded
Compare
You can preview 2c8cded at https://pr27273-2c8cded.ngbuilds.io/. |
2c8cded
to
9428c44
Compare
You can preview 9428c44 at https://pr27273-9428c44.ngbuilds.io/. |
9428c44
to
79195af
Compare
You can preview 79195af at https://pr27273-79195af.ngbuilds.io/. |
79195af
to
c421449
Compare
You can preview 6f6daa2 at https://pr27273-6f6daa2.ngbuilds.io/. |
You can preview 1a48b7c at https://pr27273-1a48b7c.ngbuilds.io/. |
@kapunahelewong Hi. See #27564. Can you work in something here about ngif else? Or make sure there are links to the API ref pages (which Judy has updates for in a separate PR)? Thanks! |
15b511a
to
a4622e3
Compare
You can preview a4622e3 at https://pr27273-a4622e3.ngbuilds.io/. |
a4622e3
to
630ef08
Compare
You can preview 630ef08 at https://pr27273-630ef08.ngbuilds.io/. |
630ef08
to
7f0af92
Compare
You can preview 7f0af92 at https://pr27273-7f0af92.ngbuilds.io/. |
7f0af92
to
1cff111
Compare
You can preview 1cff111 at https://pr27273-1cff111.ngbuilds.io/. |
Caretaker note: The Codefresh job is unrelated and still pending. I am using a global approval |
@kapunahelewong, it looks like this PR now has a conflict with master branch after merging PR 25561 that also updated .github/CODEOWNERS file. Could you please rebase this PR and resolve conflict(s)? Feel free to add "merge" label back once PR is updated. Thank you. |
1cff111
to
a16a39f
Compare
You can preview a16a39f at https://pr27273-a16a39f.ngbuilds.io/. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
This is the 7th PR of rewrites of the Template Syntax page. They all work now in Template Syntax and and are prepped for separating Template Syntax into smaller docs, each with its own example.