Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: rewrite built-in directives section of Template Syntax #27273

Closed

Conversation

kapunahelewong
Copy link
Contributor

@kapunahelewong kapunahelewong commented Nov 26, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  1. Rewritten documentation on the Built-in Directives section prose.
  2. Rebuilt example that is standalone so that it can be its own example when Built-in Directives is pulled out as its own doc.
  3. Example is more accessible (added/edited markup to help screen readers).
  4. Example is now item themed rather than hero themed.
  5. New e2e tests for the example.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This is the 7th PR of rewrites of the Template Syntax page. They all work now in Template Syntax and and are prepped for separating Template Syntax into smaller docs, each with its own example.

@kapunahelewong kapunahelewong added comp: docs aio: preview target: patch This PR is targeted for the next patch release labels Nov 27, 2018
@ngbot ngbot bot added this to the needsTriage milestone Nov 27, 2018
aio/content/guide/template-syntax.md Outdated Show resolved Hide resolved
aio/content/guide/template-syntax.md Outdated Show resolved Hide resolved
aio/content/guide/template-syntax.md Show resolved Hide resolved
aio/content/guide/template-syntax.md Outdated Show resolved Hide resolved
@mary-poppins
Copy link

You can preview 2c8cded at https://pr27273-2c8cded.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 9428c44 at https://pr27273-9428c44.ngbuilds.io/.

@jenniferfell jenniferfell added area: common Issues related to APIs in the @angular/common package feature Issue that requests a new feature action: review The PR is still awaiting reviews from at least one requested reviewer effort3: weeks comp: examples risk: medium labels Nov 29, 2018
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Nov 29, 2018
@mary-poppins
Copy link

You can preview 79195af at https://pr27273-79195af.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 6f6daa2 at https://pr27273-6f6daa2.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 1a48b7c at https://pr27273-1a48b7c.ngbuilds.io/.

@jenniferfell
Copy link
Contributor

@kapunahelewong Hi. See #27564. Can you work in something here about ngif else? Or make sure there are links to the API ref pages (which Judy has updates for in a separate PR)? Thanks!

@jenniferfell jenniferfell mentioned this pull request Dec 20, 2018
@mary-poppins
Copy link

You can preview a4622e3 at https://pr27273-a4622e3.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 630ef08 at https://pr27273-630ef08.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 7f0af92 at https://pr27273-7f0af92.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 1cff111 at https://pr27273-1cff111.ngbuilds.io/.

@brandonroberts brandonroberts removed the request for review from jenniferfell June 13, 2019 20:06
@brandonroberts brandonroberts added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 13, 2019
@ngbot ngbot bot added the action: merge The PR is ready for merge by the caretaker label Jun 13, 2019
@brandonroberts
Copy link
Contributor

Caretaker note: The Codefresh job is unrelated and still pending. I am using a global approval

@AndrewKushnir
Copy link
Contributor

@kapunahelewong, it looks like this PR now has a conflict with master branch after merging PR 25561 that also updated .github/CODEOWNERS file. Could you please rebase this PR and resolve conflict(s)? Feel free to add "merge" label back once PR is updated. Thank you.

@AndrewKushnir AndrewKushnir added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Jun 14, 2019
@mary-poppins
Copy link

You can preview a16a39f at https://pr27273-a16a39f.ngbuilds.io/.

@kapunahelewong kapunahelewong added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jun 14, 2019
AndrewKushnir pushed a commit that referenced this pull request Jun 14, 2019
@kapunahelewong kapunahelewong deleted the built-in-directives branch June 20, 2019 18:18
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker aio: preview area: common Issues related to APIs in the @angular/common package cla: yes effort3: weeks feature Issue that requests a new feature merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note risk: medium target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants