Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: set a default module_name for ts_library rules (#28051) #28241

Closed
wants to merge 1 commit into from
Closed

build: set a default module_name for ts_library rules (#28051) #28241

wants to merge 1 commit into from

Conversation

alexeagle
Copy link
Contributor

cherry-pick of 38343a2 to patch branch

@alexeagle alexeagle requested a review from alxhub January 18, 2019 18:22
@alexeagle alexeagle requested review from a team as code owners January 18, 2019 18:22
petebacondarwin
petebacondarwin approved these changes Jan 18, 2019
View reviewed changes
Copy link
Member

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for ngUpgrade and ngcc

@jasonaden jasonaden added the area: build & ci Related the build and CI infrastructure of the project label Jan 23, 2019
@ngbot ngbot bot added this to the needsTriage milestone Jan 23, 2019
@alexeagle alexeagle added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jan 25, 2019
@ngbot ngbot bot added the action: merge The PR is ready for merge by the caretaker label Jan 25, 2019
@alexeagle
Copy link
Contributor Author

Caretaker: this is a cherry-pick of a commit that already landed on master. We should merge without waiting for more approvals

jasonaden pushed a commit that referenced this pull request Jan 25, 2019
@alexeagle @jasonaden
build: set a default module_name for ts_library rules (#28051) (#28241)
cf82fbc 
PR Close #28051

PR Close #28241
@jasonaden
Copy link
Contributor

Merged in cf82fbc

@jasonaden jasonaden closed this Jan 29, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@kyliau kyliau kyliau approved these changes

@alxhub alxhub Awaiting requested review from alxhub

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.
5 participants
@alexeagle @jasonaden @petebacondarwin @kyliau @googlebot