Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and complete decorator API doc #28986

Closed
wants to merge 1 commit into from

Conversation

jbogarthyde
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Fix existing doc to be in correct places to be rendered
Add top-level descriptions and property descriptions where missing.
Edit and correct descriptions.

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #28710

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@mary-poppins
Copy link

You can preview beb0e48 at https://pr28986-beb0e48.ngbuilds.io/.

@mary-poppins
Copy link

You can preview d9aed1a at https://pr28986-d9aed1a.ngbuilds.io/.

@mary-poppins
Copy link

You can preview a47a8ca at https://pr28986-a47a8ca.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 4aa708e at https://pr28986-4aa708e.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 98ca106 at https://pr28986-98ca106.ngbuilds.io/.

packages/core/src/metadata/directives.ts Outdated Show resolved Hide resolved
packages/core/src/metadata/directives.ts Outdated Show resolved Hide resolved
packages/core/src/metadata/directives.ts Outdated Show resolved Hide resolved
packages/core/src/metadata/directives.ts Outdated Show resolved Hide resolved
packages/core/src/di/metadata.ts Show resolved Hide resolved
@mary-poppins
Copy link

You can preview 5bbe003 at https://pr28986-5bbe003.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 89fe191 at https://pr28986-89fe191.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 3b7a944 at https://pr28986-3b7a944.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 62deb87 at https://pr28986-62deb87.ngbuilds.io/.

@jbogarthyde jbogarthyde requested a review from a team as a code owner March 1, 2019 03:38
@googlebot googlebot added cla: no and removed cla: yes labels Mar 1, 2019
@mary-poppins
Copy link

You can preview 301ebe0 at https://pr28986-301ebe0.ngbuilds.io/.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Mar 4, 2019
@mary-poppins
Copy link

You can preview d895805 at https://pr28986-d895805.ngbuilds.io/.

@mary-poppins
Copy link

You can preview dae53a9 at https://pr28986-dae53a9.ngbuilds.io/.

@brandonroberts brandonroberts added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Mar 4, 2019
@ngbot ngbot bot added the action: merge The PR is ready for merge by the caretaker label Mar 4, 2019
@brandonroberts
Copy link
Contributor

Caretaker note: This is a docs only change and should not impact g3. Please run presubmit.

@AndrewKushnir AndrewKushnir added the action: presubmit The PR is in need of a google3 presubmit label Mar 4, 2019
@AndrewKushnir
Copy link
Contributor

Presubmit

@AndrewKushnir AndrewKushnir added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Mar 4, 2019
@AndrewKushnir
Copy link
Contributor

@jbogarthyde, @brandonroberts there was a conflict while merging this PR into patch branch, so I've merged it to master only. Could you please create a version of this PR against patch (7.2.x) branch? Thank you.

@AndrewKushnir AndrewKushnir removed the action: presubmit The PR is in need of a google3 presubmit label Mar 4, 2019
AndrewKushnir pushed a commit to AndrewKushnir/angular that referenced this pull request Mar 5, 2019
AndrewKushnir pushed a commit that referenced this pull request Mar 5, 2019
@jbogarthyde jbogarthyde deleted the jb-apidoc-decorators branch March 5, 2019 16:15
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes effort2: days merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants