Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix and add decorator api doc (#28986) [backport for patch branch] #29112

Closed
wants to merge 1 commit into from

Conversation

AndrewKushnir
Copy link
Contributor

Backport of the "docs: fix and add decorator api doc" commit from master to patch branch.

PR Close #28986

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

Does this PR introduce a breaking change?

  • Yes
  • No

@AndrewKushnir AndrewKushnir added comp: docs action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 5, 2019
@AndrewKushnir AndrewKushnir requested review from a team as code owners March 5, 2019 01:34
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@ngbot ngbot bot added this to the needsTriage milestone Mar 5, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@AndrewKushnir AndrewKushnir mentioned this pull request Mar 5, 2019
13 tasks
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 5, 2019
AndrewKushnir pushed a commit that referenced this pull request Mar 5, 2019
@AndrewKushnir
Copy link
Contributor Author

Merged this PR as a backport of the "docs: fix and add decorator api doc" commit from master to patch branch with @jbogarthyde review and approval. Thank you.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants