Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): parse incorrect ML open tag as text #29328

Closed
wants to merge 1 commit into from
Closed

fix(core): parse incorrect ML open tag as text #29328

wants to merge 1 commit into from

Commits on Mar 15, 2019

  1. fix(core): parse incorrect ML open tag as text 

    This PR alligns markup language lexer with the previous behaviour in version 7.x:
https://stackblitz.com/edit/angular-iancj2

While this behaviour is not perfect (we should be giving users an error message
here about invalid HTML instead of assuming text node) this is probably best we
can do without more substential re-write of lexing / parsing infrastructure.

This PR just fixes angular#29231 and restores VE behaviour - a more elaborate fix will
be done in a separate PR as it requries non-trivial rewrites.
    @pkozlowski-opensource
    pkozlowski-opensource committed Mar 15, 2019
    Copy the full SHA
    e4657e6 View commit details
    Browse the repository at this point in the history