Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(upgrade): work around SauceLabs issue with loading AngularJS files #29603

Closed
wants to merge 3 commits into from
Closed

test(upgrade): work around SauceLabs issue with loading AngularJS files #29603

wants to merge 3 commits into from

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Mar 29, 2019

Sometimes (especially on mobile browsers on SauceLabs) the script may fail to load due to a temporary issue with the internet connection. To avoid flakes on CI when this happens, we retry the download after some delay.

Related to #28578.

@gkalpak
test(upgrade): work around SauceLabs issue with loading AngularJS files
a271308 
Sometimes (especially on mobile browsers on SauceLabs) the script may
fail to load due to a temporary issue with the internet connection. To
avoid flakes on CI when this happens, we retry the download after some
delay.

Related to angular#28578.
@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project effort1: hours target: patch This PR is targeted for the next patch release risk: low area: upgrade Issues related to AngularJS → Angular upgrade APIs labels Mar 29, 2019
@ngbot ngbot bot added this to the needsTriage milestone Mar 29, 2019
@gkalpak gkalpak force-pushed the test-upgrade-saucelabs-flakes branch 3 times, most recently from 569b57e to a271308 Compare March 30, 2019 11:24
@mary-poppins
Copy link

You can preview a271308 at https://pr29603-a271308.ngbuilds.io/.

@gkalpak
Copy link
Member Author

gkalpak commented Mar 30, 2019 •
edited
Loading

Test-drived this with 33 CircleCI jobs all of which succeeded. Two of those would have failed without the retry 🎉

✔️ All 33 jobs (click to expand)

266617, 266619, 266620, 266621, 266622,
266623, 266624, 266625, 266626, 266627,
266628, 266708, 266709, 266710, 266711,
266712, 266713, 266714, 266715, 266716,
266717, 266718, 266758, 266759, 266760,
266761, 266762, 266763, 266764, 266765,
266766, 266768, 266769

♻️ The 2 jobs that had to retry (click to expand)

✨ So, it seems to work ✨
(Even if it doesn't eliminate the flakes entirely, it should reduce the rate significantly:tm:)

@gkalpak gkalpak marked this pull request as ready for review March 30, 2019 11:50
@gkalpak gkalpak requested a review from a team as a code owner March 30, 2019 11:50
petebacondarwin
petebacondarwin approved these changes Mar 30, 2019
View reviewed changes
Copy link
Member

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@mary-poppins
Copy link

You can preview cab85b4 at https://pr29603-cab85b4.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 909dbd8 at https://pr29603-909dbd8.ngbuilds.io/.

@jasonaden jasonaden closed this in 2ff3d2d Apr 1, 2019
jasonaden pushed a commit that referenced this pull request Apr 1, 2019
@gkalpak @jasonaden
test(upgrade): work around SauceLabs issue with loading AngularJS fil…
15193fc 
…es (#29603)

Sometimes (especially on mobile browsers on SauceLabs) the script may
fail to load due to a temporary issue with the internet connection. To
avoid flakes on CI when this happens, we retry the download after some
delay.

Related to #28578.

PR Close #29603
@gkalpak gkalpak deleted the test-upgrade-saucelabs-flakes branch April 1, 2019 18:02
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@gkalpak @wKoza
test(upgrade): work around SauceLabs issue with loading AngularJS fil…
657d806 
…es (angular#29603)

Sometimes (especially on mobile browsers on SauceLabs) the script may
fail to load due to a temporary issue with the internet connection. To
avoid flakes on CI when this happens, we retry the download after some
delay.

Related to angular#28578.

PR Close angular#29603
@gkalpak gkalpak mentioned this pull request Jun 5, 2019
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project area: upgrade Issues related to AngularJS → Angular upgrade APIs cla: yes effort1: hours risk: low target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.
4 participants
@gkalpak @mary-poppins @petebacondarwin @googlebot