Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update product-alerts.component.1.ts #29917

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@bradlygreen
Copy link
Member

bradlygreen commented Apr 15, 2019

Make the example match the generated output seen in StackBlitz as shown https://next.angular.io/getting-started#input step 2 "Open product-alerts.component.ts."

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@bradlygreen bradlygreen requested a review from angular/fw-docs-intro as a code owner Apr 15, 2019

@googlebot googlebot added the cla: yes label Apr 15, 2019

@ngbot

This comment has been minimized.

Copy link

ngbot bot commented Apr 16, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: integration_test" is failing
    failure status "ci/circleci: test_aio" is failing
    pending missing required status "ci/circleci: publish_snapshot"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@IgorMinar
Copy link
Member

IgorMinar left a comment

CI fails because of the trailing whitespace, please fix.

@googlebot

This comment has been minimized.

Copy link

googlebot commented Apr 16, 2019

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Apr 16, 2019

@googlebot

This comment has been minimized.

Copy link

googlebot commented Apr 16, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Apr 16, 2019

@benlesh benlesh added the comp: docs label Apr 17, 2019

@ngbot ngbot bot added this to the needsTriage milestone Apr 17, 2019

@benlesh

This comment has been minimized.

Copy link
Contributor

benlesh commented Apr 17, 2019

@bradlygreen Looks like you just need to squash your commits and this is good to go.

docs: update product-alerts.component.1.ts
Make the example match the generated output seen in StackBlitz as shown https://next.angular.io/getting-started#input step 2 "Open product-alerts.component.ts."

@benlesh benlesh force-pushed the bradlygreen-patch-4 branch from ce95d97 to 88654dd Apr 17, 2019

@benlesh

This comment has been minimized.

Copy link
Contributor

benlesh commented Apr 17, 2019

Caretaker note: test_aio CI was failing because this was an edit via the GitHub UI... merging.

@benlesh benlesh closed this in c0ec1d6 Apr 17, 2019

@benlesh benlesh deleted the bradlygreen-patch-4 branch Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.