Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ivy): coalesced listeners should preventDefault if any returns false #29934

Closed
wants to merge 1 commit into from
Closed

fix(ivy): coalesced listeners should preventDefault if any returns false #29934

wants to merge 1 commit into from

Commits on Apr 16, 2019

  1. fix(ivy): coalesced listeners should preventDefault if any returns false 

    We had a bug where event.preventDefault() was not always called if listeners
were coalesced. This is because we were overwriting the previous listener's
result every time we called the next listener, so listeners early in the chain
that returned false would be ignored and preventDefault would not be called.

This commit fixes that issue, so now preventDefault() is called if any listener
in a coalesced chain returns false. This brings us in line with View Engine
behavior.
    @kara
    kara committed Apr 16, 2019
    Copy the full SHA
    da05752 View commit details
    Browse the repository at this point in the history