Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): Directly spawn native Bazel binary #30306

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@kyliau
Copy link
Member

commented May 7, 2019

Instead of launching a Node.js process that in turn spawns Bazel binary,
the Builder could now directly spawn the native binary. This makes the
bootup process slightly more efficient, and allows the Builder to
control spawn options. This works with both Bazel and iBazel.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau requested a review from alexeagle May 7, 2019

@kyliau kyliau requested a review from angular/tools-bazel as a code owner May 7, 2019

@ngbot ngbot bot added this to the needsTriage milestone May 7, 2019

@googlebot googlebot added the cla: yes label May 7, 2019

fix(bazel): Directly spawn native Bazel binary
Instead of launching a Node.js process that in turn spawns Bazel binary,
the Builder could now directly spawn the native binary. This makes the
bootup process slightly more efficient, and allows the Builder to
control spawn options. This works with both Bazel and iBazel.

@kyliau kyliau force-pushed the kyliau:bazel branch from 5ff2cc4 to 35d3f1f May 7, 2019

alxhub added a commit that referenced this pull request May 7, 2019

fix(bazel): Directly spawn native Bazel binary (#30306)
Instead of launching a Node.js process that in turn spawns Bazel binary,
the Builder could now directly spawn the native binary. This makes the
bootup process slightly more efficient, and allows the Builder to
control spawn options. This works with both Bazel and iBazel.

PR Close #30306

@alxhub alxhub closed this in 2a0f497 May 7, 2019

BioPhoton added a commit to BioPhoton/angular that referenced this pull request May 21, 2019

fix(bazel): Directly spawn native Bazel binary (angular#30306)
Instead of launching a Node.js process that in turn spawns Bazel binary,
the Builder could now directly spawn the native binary. This makes the
bootup process slightly more efficient, and allows the Builder to
control spawn options. This works with both Bazel and iBazel.

PR Close angular#30306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.