Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): Load global stylesheet in dev and prod #30879

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@kyliau
Copy link
Member

commented Jun 5, 2019

Global stylesheet should be injected as a <link> tag in index.html for
both dev and prod app.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau requested a review from angular/tools-bazel as a code owner Jun 5, 2019

@ngbot ngbot bot added this to the needsTriage milestone Jun 5, 2019

@googlebot googlebot added the cla: yes label Jun 5, 2019

@kyliau kyliau force-pushed the kyliau:global_stylesheet branch from e4a8fd9 to 31b3c4c Jun 5, 2019

@kyliau kyliau requested review from alexeagle and alan-agius4 Jun 5, 2019

@alexeagle
Copy link
Contributor

left a comment

how could this be tested?

@alan-agius4
Copy link
Contributor

left a comment

Couple of small NIT, but looks good.

fix(bazel): Load global stylesheet in dev and prod
Global stylesheet should be injected as a <link> tag in index.html for
both dev and prod app.

@kyliau kyliau force-pushed the kyliau:global_stylesheet branch from 31b3c4c to 181ca99 Jun 5, 2019

mhevery added a commit that referenced this pull request Jun 6, 2019

fix(bazel): Load global stylesheet in dev and prod (#30879)
Global stylesheet should be injected as a <link> tag in index.html for
both dev and prod app.

PR Close #30879

@mhevery mhevery closed this in 17bfedd Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.