-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set type assertion to the recommended way #31042
Set type assertion to the recommended way #31042
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Accidentally copy pasted the wrong commit message. I'll fix that |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Angular uses tslint:recommended by default. The default for no-angle-bracket-type-assertion is true See https://github.com/palantir/tslint/blob/master/src/configs/recommended.ts#L69
2e73a0b
to
a135dac
Compare
If you agree with this change I can also scan for more places in the documentation that use the previous syntax and fix those as well. Just let me know! 🙂 |
thank you for the contribution @kroeder ! |
merge-assistance: global approval |
Angular uses tslint:recommended by default. The default for no-angle-bracket-type-assertion is true See https://github.com/palantir/tslint/blob/master/src/configs/recommended.ts#L69 PR Close #31042
Angular uses tslint:recommended by default. The default for no-angle-bracket-type-assertion is true See https://github.com/palantir/tslint/blob/master/src/configs/recommended.ts#L69 PR Close angular#31042
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The doc for User Input uses
Angular CLI generates a
tslint
that usestslint:recommended
by default and the recommended type assertion value is"no-angle-bracket-type-assertion": true,
Issue Number: N/A
What is the new behavior?
Set
to
Does this PR introduce a breaking change?
Other information