Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(service-worker): registration failed on Safari #31140

Closed
wants to merge 1 commit into from
Closed

fix(service-worker): registration failed on Safari #31140

wants to merge 1 commit into from

Commits on Jun 24, 2019

  1. fix(service-worker): registration failed on Safari 

    Since Angular v8, and commit b3dda0e, `parseUrl()` can be called without
`relativeTo`, thus `new URL()` can be called with `relativeTo = undefined`.

Safari does not like it and the service worker registration fails:
```js
new URL('https://angular.io/') // OK
new URL('https://angular.io/', undefined) // TypeError
```

Closes angular#31061
    @H--o-l
    H--o-l committed Jun 24, 2019
    Copy the full SHA
    36066a9 View commit details
    Browse the repository at this point in the history