Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
fix(ngcc): handle compilation diagnostics #31996
Previously, any diagnostics reported during the compilation of an
This commit introduces behavior to deal with error diagnostics in a more
2 times, most recently
Aug 8, 2019
Oh no! We don't currently have a Windows CI as Codefresh configuration was recently removed. I deliberately did not rebase my branch hoping that Codefresh would still run on the branch, but that doesn't appear to be the case :-(
As discussed "offline":
The difference being that the actual error ends with
...to something like...
...makes all tests pass.
I am not sure what is the best way to solve this (e.g. normalize newlines in ts.formatDiagnostics() or fix the assertions, etc.). but normalizing newlines to