Tslib as peerDependency #32167

alan-agius4 · 2019-08-16T14:44:01Z

feat: change tslib from direct dependency to peerDependency

BREAKING CHANGE:

We no longer directly have a direct depedency on tslib. Instead it is now listed a peerDependency.

Users not using the CLI will need to manually install tslib via;

yarn add tslib

or

npm install tslib --save

Reference: TOOL-836

alan-agius4 · 2019-08-16T14:51:05Z

When this gets approved and merged will do the same changes to https://github.com/dherges/ng-packagr and the https://github.com/angular/angular-cli/blob/master/packages/schematics/angular/library/files/package.json.template

alan-agius4 · 2019-08-16T16:03:49Z

Will look into the failures over the weekend.

@gkalpak, can you give me a tip we I should be looking for the docs failures? Thanks

alan-agius4 · 2019-08-17T08:24:30Z

CI is green.

IgorMinar

Why this change? I have two concerns:

umd bundles are now no longer self-contained, breaking universal and anyone relying on umd
the change from dep to peerDep requires a migration, but none is attached in this change

Can we please first discuss the motivation behind this and then we can decide if we want to go forward or not? thanks

alan-agius4 · 2019-08-26T10:21:12Z

Hi @IgorMinar, thanks for taking a look.

umd bundles are now no longer self-contained, breaking universal and anyone relying on umd

No fully understanding why this breaks universal apart from when not having tslib as a dev dependency,

I do agree that UMD bundles are not "self-contained" to an extend since RxJs is not embedded either. But yes, it will break users using UMD's such as system.js users.

the change from dep to peerDep requires a migration, but none is attached in this change

Indeed a migration needs to be added, though that should be trivial to that and most of the CLI users are already using tslib. As it's already added to devDepedencies since importHelpers is enabled by default.

Can we please first discuss the motivation behind this and then we can decide if we want to go forward or not?

The main motivation for this is that tslib is included entirely in all the UMD bundles.
For example, if a users adds 4 UMDs bundles in their application each of these 4 bundles will contain a full version of tslib.

I am not sure if @alexeagle had some other reasons for this, apart from what I mentioned, since he originally opened the issue (TOOL-836)

Though, I'd like an answer to a question. Why a dependency on tslib is different then let's say RxJs which is always a peerDepedency, it is because it's a small dependency (approx 12Kb unminified) or there are other motivations?

Thanks

alexeagle · 2019-08-27T12:57:15Z

I'm pretty sure the request came from @IgorMinar originally, as a way to trim bundle sizes.

petebacondarwin · 2019-10-07T09:12:45Z

@IgorMinar what are we going to do about this PR?

petebacondarwin · 2019-10-07T09:14:07Z

We should get approval from @IgorMinar and then this will need a new rebase @alan-agius4

IgorMinar

summarizing the in person discussion:

let's change the PR to keep on inlining the tslib into umd bundles (umd is used on CDNs and we don't have way to not making this change a breaking one, which would require everyone who depends on umds update their index.html or whatever module loader / resolver they use.
let's include a migration that ensure that all cli projects have tslib installed as a dependency.
let's include this migration in the list of @kara's migrations for v9

otherwise lgtm

alan-agius4 · 2019-10-09T14:05:05Z

Migration to ensure that tslib is installed angular/angular-cli#15800

…lled (#15800) Related to: angular/angular#32167

BREAKING CHANGE: We no longer directly have a direct depedency on `tslib`. Instead it is now listed a `peerDependency`. Users not using the CLI will need to manually install `tslib` via; ``` yarn add tslib ``` or ``` npm install tslib --save ```

alan-agius4 · 2019-10-14T15:14:04Z

@IgorMinar, I marked this PR for merge, I added the migration to @kara's list and added a migration to ensure tslib is installed. angular/angular-cli#15800

I also rolled out the changes to components and universal
angular/universal#1278
angular/components#17393

alan-agius4 · 2019-10-14T16:12:44Z

Caretaker: @IgorMinar approved!

nguniversal relied on a hidden dependency of `tslib` due to `importHelpers` https://github.com/angular/universal/blob/5798f198db1fb0bce9dbfb850751429a3724084a/modules/bazel-tsconfig-build.json#L11 which was previously installed by the Angular framework. This, however changed with this PR angular/angular#32167 With this change we now list `tslib` as a required peerDepedency. Users not using the CLI will need to manually install `tslib` via; ``` yarn add tslib ``` or ``` npm install tslib --save ``` Reference: TOOL-836

…32167) BREAKING CHANGE: We no longer directly have a direct depedency on `tslib`. Instead it is now listed a `peerDependency`. Users not using the CLI will need to manually install `tslib` via; ``` yarn add tslib ``` or ``` npm install tslib --save ``` PR Close angular#32167

… package.json This is to align with angular/angular#32167

…32167) BREAKING CHANGE: We no longer directly have a direct depedency on `tslib`. Instead it is now listed a `peerDependency`. Users not using the CLI will need to manually install `tslib` via; ``` yarn add tslib ``` or ``` npm install tslib --save ``` PR Close angular#32167

angular-automatic-lock-bot · 2019-11-14T16:09:39Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

alan-agius4 requested review from a team as code owners August 16, 2019 14:44

googlebot added the cla: yes label Aug 16, 2019

alan-agius4 requested review from alexeagle and IgorMinar August 16, 2019 14:44

alan-agius4 added target: major This PR is targeted for the next major release action: review The PR is still awaiting reviews from at least one requested reviewer PR action: time-zone area: bazel Issues related to the published `@angular/bazel` build rules labels Aug 16, 2019

ngbot bot added this to the needsTriage milestone Aug 16, 2019

alan-agius4 assigned alexeagle and IgorMinar Aug 16, 2019

alan-agius4 requested review from a team as code owners August 16, 2019 15:19

alan-agius4 added state: WIP and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 16, 2019

alan-agius4 removed the state: WIP label Aug 17, 2019

alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer breaking changes labels Aug 17, 2019

IgorMinar suggested changes Aug 23, 2019

View reviewed changes

IgorMinar approved these changes Oct 8, 2019

View reviewed changes

alan-agius4 mentioned this pull request Oct 9, 2019

feat(@schematics/angular): add migration ensure that tslib is insta… angular/angular-cli#15800

Merged

mgechev pushed a commit to angular/angular-cli that referenced this pull request Oct 9, 2019

feat(@schematics/angular): add migration ensure that tslib is insta…

08bc4df

…lled (#15800) Related to: angular/angular#32167

This was referenced Oct 14, 2019

feat: change tslib from direct dependency to peerDependency angular/components#17393

Merged

feat: add tslib as peerDependency angular/universal#1278

Merged

alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 14, 2019

alan-agius4 added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Oct 14, 2019

mhevery closed this in e2d5bc2 Oct 14, 2019

alan-agius4 deleted the tslib-peer-deps branch October 14, 2019 16:37

vikerman pushed a commit to angular/angular-cli that referenced this pull request Oct 22, 2019

feat(@schematics/angular): add tslib as a peerDependencies in library…

a384a98

… package.json This is to align with angular/angular#32167

angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tslib as peerDependency #32167

Tslib as peerDependency #32167

alan-agius4 commented Aug 16, 2019 •

edited

alan-agius4 commented Aug 16, 2019 •

edited

alan-agius4 commented Aug 16, 2019

alan-agius4 commented Aug 17, 2019

IgorMinar left a comment

alan-agius4 commented Aug 26, 2019 •

edited

alexeagle commented Aug 27, 2019

petebacondarwin commented Oct 7, 2019

petebacondarwin commented Oct 7, 2019

IgorMinar left a comment

alan-agius4 commented Oct 9, 2019

alan-agius4 commented Oct 14, 2019

alan-agius4 commented Oct 14, 2019 •

edited

angular-automatic-lock-bot bot commented Nov 14, 2019

Tslib as peerDependency #32167

Tslib as peerDependency #32167

Conversation

alan-agius4 commented Aug 16, 2019 • edited

alan-agius4 commented Aug 16, 2019 • edited

alan-agius4 commented Aug 16, 2019

alan-agius4 commented Aug 17, 2019

IgorMinar left a comment

Choose a reason for hiding this comment

alan-agius4 commented Aug 26, 2019 • edited

alexeagle commented Aug 27, 2019

petebacondarwin commented Oct 7, 2019

petebacondarwin commented Oct 7, 2019

IgorMinar left a comment

Choose a reason for hiding this comment

alan-agius4 commented Oct 9, 2019

alan-agius4 commented Oct 14, 2019

alan-agius4 commented Oct 14, 2019 • edited

angular-automatic-lock-bot bot commented Nov 14, 2019

alan-agius4 commented Aug 16, 2019 •

edited

alan-agius4 commented Aug 16, 2019 •

edited

alan-agius4 commented Aug 26, 2019 •

edited

alan-agius4 commented Oct 14, 2019 •

edited