This repository was archived by the owner on Nov 22, 2024. It is now read-only.
feat: add tslib as peerDependency #1278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: minor
alan-agius4
requested review from
CaerusKaru,
MarkPieszak and
Toxicable
as code owners
Collaborator
Author
|
Also related to angular/angular#32167 |
nguniversal, relied on a hidden dependency of `tslib` due to `importHelpers` https://github.com/angular/universal/blob/5798f198db1fb0bce9dbfb850751429a3724084a/modules/bazel-tsconfig-build.json#L11 which was previously installed by the Angular framework. This, however changed with this PR angular/angular#32167 With this change we now list `tslib` as a required peerDepedency. Users not using the CLI will need to manually install `tslib` via; ``` yarn add tslib ``` or ``` npm install tslib --save ``` Reference: TOOL-836
alan-agius4
changed the title
CaerusKaru
approved these changes
Oct 15, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add tslib as peerDependency
nguniversal, relied on a hidden dependency of
tslibdue toimportHelpersuniversal/modules/bazel-tsconfig-build.json
Line 11 in 5798f19
With this change we now list
tslibas a required peerDepedency.Users not using the CLI will need to manually install
tslibvia;or
Reference: TOOL-836