-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: create Issue and Pull Request markdown doc, explaining automatic locking policy #32405
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
<a name="conversation-locking"></a> | ||
# Automatic conversation locking | ||
Closed issues and pull requests are locked automatically after 30 days of inactivity. | ||
|
||
## I want to comment on a locked conversation, what should I do? | ||
When an issue has been closed and inactive for over 30 days, the original context is likely outdated. | ||
If you encounter a similar or related issue in the current version, please open a new issue and | ||
provide up-to-date reproduction instructions. | ||
|
||
## Why lock conversations? | ||
Automatically locking closed, inactive issues guides people towards filing new issues with updated | ||
context rather than commenting on a "resolved" issue that contains out-of-date or unrelated | ||
information. As an example, someone may comment "I'm still having this issue", but without | ||
providing any of the additional information the team needs to investigate. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the plan is for this document to expand in the future and contain more sections (on things other than converstation locking), then I assume we would link to specific section (not the file as a whole):
GitHub will automatically create anchors for headings, based on the heading text. This is hanydy, but it means that the comment template needs to be updated every time we tweak the heading.
If linking to specific section is indeed the intention, a better alternative is to use explicit anchor (which are independent of the heading text); e.g.:
This way, we can link to
...GITHUB_PROCESS.md#conversation-locking
and the link will still work if the heading text modified later.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we would be linking to the specific section. Though we shouldn't have to change the heading title, or at least not too often.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the anchor