fix(ivy): match class and attribute value without case-sensitivity #32548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds two acceptance tests to show a current difference in behavior between Ivy and VE. A directive with a selector `.Titledir` matches an element with `class="titleDir"` in VE but not in Ivy. Same thing for an attribute value.
Prior to this commit, a directive with a selector `selector=".Titledir"` would not match an element like `div class="titleDir"` in Ivy whereas it would in VE. The same issue was present for `selector="[title=Titledir]` and `title="titleDir"`. This fixes the Ivy behavior by changing the matching algorithm to use lowercased values. Note that some `render3` tests needed to be changed to reflect that the compiler generates lowercase selectors. These tests are in the process to be migrated to `acceptance` to use `TestBed` in another PR anyway.
cexbrayat
force-pushed
the
fix/case-insensitive-match
branch
from
758c99b
to
952ad69
Compare
pkozlowski-opensource
added
comp: ivy
action: review
pkozlowski-opensource
approved these changes
Sep 9, 2019
kara
added
action: presubmit
kara
added
action: merge
matsko
pushed a commit
that referenced
this pull request
Sep 10, 2019
…32548) Prior to this commit, a directive with a selector `selector=".Titledir"` would not match an element like `div class="titleDir"` in Ivy whereas it would in VE. The same issue was present for `selector="[title=Titledir]` and `title="titleDir"`. This fixes the Ivy behavior by changing the matching algorithm to use lowercased values. Note that some `render3` tests needed to be changed to reflect that the compiler generates lowercase selectors. These tests are in the process to be migrated to `acceptance` to use `TestBed` in another PR anyway. PR Close #32548
14 tasks
14 tasks
arnehoek
pushed a commit
to arnehoek/angular
that referenced
this pull request
Sep 26, 2019
Adds two acceptance tests to show a current difference in behavior between Ivy and VE. A directive with a selector `.Titledir` matches an element with `class="titleDir"` in VE but not in Ivy. Same thing for an attribute value. PR Close angular#32548
arnehoek
pushed a commit
to arnehoek/angular
that referenced
this pull request
Sep 26, 2019
…ngular#32548) Prior to this commit, a directive with a selector `selector=".Titledir"` would not match an element like `div class="titleDir"` in Ivy whereas it would in VE. The same issue was present for `selector="[title=Titledir]` and `title="titleDir"`. This fixes the Ivy behavior by changing the matching algorithm to use lowercased values. Note that some `render3` tests needed to be changed to reflect that the compiler generates lowercase selectors. These tests are in the process to be migrated to `acceptance` to use `TestBed` in another PR anyway. PR Close angular#32548
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Prior to this commit, a directive with a selector
selector=".Titledir"would not match an element likediv class="titleDir"in Ivy whereas it would in VE. The same issue was present forselector="[title=Titledir]andtitle="titleDir".What is the new behavior?
This fixes the Ivy behavior by changing the matching algorithm to use lowercased values.
Does this PR introduce a breaking change?
(well it can if someone was relying on Ivy behaving differently than VE, but I don't think it is the case).
Other information
Note that some
render3tests needed to be changed to reflect that the compiler generates lowercase selectors. These tests are in the process to be migrated toacceptanceto useTestBedin another PR anyway.